✨ Add ServedVersionValidator preflight check #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
==========================================
+ Coverage 75.45% 77.56% +2.10%
==========================================
Files 35 36 +1
Lines 1919 1979 +60
==========================================
+ Hits 1448 1535 +87
+ Misses 329 309 -20
+ Partials 142 135 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
everettraven
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Overall the changes look really good! Great work @trgeiger !
I have a couple minor comments, but ones I think are worth addressing
New preflight check that checks for either the presence of the "Webhook" conversion strategy to pass, or checks for any incompatible changes between served versions in the new CRD which, if found, causes failure.. Closes operator-framework#1091 Signed-off-by: Tayler Geiger <[email protected]>
|
Thanks for the review and suggestions. All ready to go again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New preflight check that checks for either the presence of the "Webhook" conversion strategy to pass, or checks for any incompatible changes between served versions in the new CRD which, if found, causes failure..
Closes #1091
Description
Adds a new preflight check, ServedVersionValidator, which checks for breaking changes between served versions in the new CRD when upgrading.
Happy to change up any naming or error messages.
Existing test data had to be edited so it wouldn't trigger the new check--the empty v1 in all the test data has just been filled in to match the test data v2.
Reviewer Checklist