✨ Add in catalog label selection support #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Short <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Adding a reference to #1110 here, so it doesn't get resolved when this is merged... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
- Coverage 75.45% 75.37% -0.08%
==========================================
Files 35 35
Lines 1919 1925 +6
==========================================
+ Hits 1448 1451 +3
- Misses 329 331 +2
- Partials 142 143 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dtfranz
reviewed
Aug 22, 2024
dtfranz
reviewed
Aug 22, 2024
Signed-off-by: Todd Short <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
operator-framework:main
with commit Aug 22, 2024
245e580
16 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1112
Adds some tests to validate the label selector.
Modified some tests to add labels and selectors. They are not necessary now, but will be once 1110 is resolved; as that issue adds the ambiguity that this PR helps resolve.
Description
Reviewer Checklist