🐛 Revert "✨ Wire up Service Account (#1038)" #1072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 95b9f0d.
joelanford
changed the title
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The "Verify PR title" test is failing because I have an Issue/PR number in the title. In this case, I think it makes sense for the title to reference the PR that we're reverting, so I'm going to ignore that error. |
grokspawn
approved these changes
Jul 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
+ Coverage 72.59% 72.85% +0.25%
==========================================
Files 31 31
Lines 1883 1864 -19
==========================================
- Hits 1367 1358 -9
+ Misses 377 371 -6
+ Partials 139 135 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 95b9f0d.
Description
This reverts the #1038, which breaks the standard install of OLMv1.
It appears that the code from #1038 still requires the OLMv1 system service account to have
* / * / *permissions (or at least permission to list/watch everything).The e2e tests from that PR pass because they layer
* / * / *permissions back in for both the OLM SA and the ClusterExtension SA, which means that our SA features are essentially untested.Reviewer Checklist