✨ bump helm-operator-plugins to v0.3.0; disable failure rollbacks #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joelanford
force-pushed
the
disable-automatic-rollback
branch
from
c69ef81 to
06d987e
Compare
openshift-merge-robot
removed
the
needs-rebase
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
==========================================
+ Coverage 78.05% 78.07% +0.02%
==========================================
Files 18 18
Lines 1253 1259 +6
==========================================
+ Hits 978 983 +5
- Misses 193 194 +1
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
With the failure rollbacks disabled, I am seeing the expected exponential backoffs retrying (and still failing; in my case I changed a manifest to be invalid, so i expect permafailure). And then when I patch the clusterextension to allow choosing a working version, I see that upgrade go through and the installation succeed. |
- disable failure rollbacks - set max helm release history to 10 Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
disable-automatic-rollback
branch
from
06d987e to
caf4d3d
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
joelanford
changed the title
grokspawn
approved these changes
Jul 9, 2024
perdasilva
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
- disable failure rollbacks - set max helm release history to 10 Signed-off-by: Joe Lanford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps to a new version of helm-operator-plugins, which brings a few new fixes, features, and changes. Notably:
This PR also:
lookuptemplate function).For all changes, see https://github.com/operator-framework/helm-operator-plugins/releases/tag/v0.3.0
Closes #994
Reviewer Checklist