-
Notifications
You must be signed in to change notification settings - Fork 66
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.v1.0Issues related to the initial stable release of OLMv1Issues related to the initial stable release of OLMv1
Description
I haven't had a chance to attempt a reproduction yet, but looking at our code, I think we have a few problems if installNamespace changes on a ClusterExtension that has a successful installation.
- We will not find the installed version in the previous install namespace, so our reconciler will treat it like a new install (assuming a helm release in the new install namespace doesn't already exist)
- We will not do anything with the helm release in the previous install namespace, which essentially means orphaning it.
- I don't know for sure, but there may be issues transferring any shared objects between the old and new release manifests.
Options include:
- Make the
spec.installNamespace
field immutable. This has implications on users that want to relocate a cluster extension. We would likely needspec.deletionPolicy: orphan
to make this tolerable to those users. - Stop using helm releases. Use
helm template
instead? This has implications on support for helm hooks, but perhaps we detect and reject manifests that use hooks. This option would eliminate the problem described in BUG: data too long issue rendering #923 as well.
Any other options folks can think of?
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.v1.0Issues related to the initial stable release of OLMv1Issues related to the initial stable release of OLMv1
Type
Projects
Status
Done