-
Notifications
You must be signed in to change notification settings - Fork 66
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.v1.0Issues related to the initial stable release of OLMv1Issues related to the initial stable release of OLMv1
Description
Another thing I just found. We setup finalizers in main.go
, but then don't actually set them on the reconciler or call Finalize
during reconciliation. I tried updating to do these things, but then the controller started panic-ing because the finalizer expects to finalize a BundleDeployment, but we are now trying to finalize a ClusterExtension.
Originally posted by @joelanford in #903 (comment)
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.v1.0Issues related to the initial stable release of OLMv1Issues related to the initial stable release of OLMv1
Type
Projects
Status
Done