Skip to content

Fix: finalizers not set on ClusterExtension #942

@joelanford

Description

@joelanford

Another thing I just found. We setup finalizers in main.go, but then don't actually set them on the reconciler or call Finalize during reconciliation. I tried updating to do these things, but then the controller started panic-ing because the finalizer expects to finalize a BundleDeployment, but we are now trying to finalize a ClusterExtension.

Originally posted by @joelanford in #903 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.v1.0Issues related to the initial stable release of OLMv1

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions