fix: condition for bulk resources #1688
Conversation
|
closes #1687 |
|
The test for some reason does not fail. Will investigate also that. |
csviri
force-pushed
the
bulk-precondition
branch
from
d83b9f8 to
42a4e17
Compare
csviri
changed the title
| return condition.map(c -> c.isMet(primary, | ||
| dependentResource.getSecondaryResource(primary, context).orElse(null), | ||
| context)) | ||
| (R) resources, context)) |
There was a problem hiding this comment.
This shouldn't work because R can never be a Map in a DependentResource declaration so this should most likely cause a ClassCastException.
There was a problem hiding this comment.
That thing does not get into the bytecode, but also there is a test for this in the PR. Will try to make it more nice though.
There was a problem hiding this comment.
Checked but this is still the simplest way to do locally, this will change probably within this issue:
#1689
There was a problem hiding this comment.
will improve this sample so it shows more the issue with the Bulk resources.
|
@metacosm improved the test, commented it, would be quite unefficient to do a real life example, but I think here the main point is the API to show in the IT. |
|
Kudos, SonarCloud Quality Gate passed! |
Note that this is a temp fix for 4.2. A proper fix with API change will come in 4.3 probably with this PR:
#1690