Skip to content

Condition API for Dependent Resources Should Contain the Dependent Resource not the Actual Resource #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csviri opened this issue Jan 2, 2023 · 0 comments · Fixed by #1690

Comments

@csviri
Copy link
Collaborator

csviri commented Jan 2, 2023

See this report for some details: #1687

The idea is to change back (was like this before) the API of the Condition to not only handle the resource:

boolean isMet(P primary, R secondary, Context<P> context);

but rather the dependent resource:

boolean isMet(P primary, D dependentResource, Context<P> context);

Rational: This will make a more generic api, where the distinction if its a bulk managed resource or other is done within the implementation. In case some implements a custom dependent resource and provides some additional functionalities that could be accessed also more elegantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant