Skip to content

refactor: deleteBulkResource -> deleteTargetResource #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 17, 2022
Merged

refactor: deleteBulkResource -> deleteTargetResource #1544

merged 4 commits into from
Oct 17, 2022

Conversation

metacosm
Copy link
Collaborator

  • refactor: deleteBulkResource -> deleteTargetResource
  • refactor: remove now unneeded class

@metacosm metacosm self-assigned this Oct 13, 2022
@metacosm metacosm requested a review from csviri October 13, 2022 13:42
@metacosm metacosm mentioned this pull request Oct 13, 2022
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 21 Code Smells

23.6% 23.6% Coverage
0.0% 0.0% Duplication

csviri
csviri approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm metacosm merged commit 5a0cb3a into next Oct 17, 2022
@metacosm metacosm deleted the refine branch October 17, 2022 19:18
csviri pushed a commit that referenced this pull request Oct 19, 2022
@metacosm @csviri
refactor: deleteBulkResource -> deleteTargetResource (#1544)
15e30f1 
* refactor: deleteBulkResource -> deleteTargetResource

* refactor: remove now unneeded class

* refactor: deleteBulkResourcesIfRequired -> deleteExtraResources

* fix: javadoc
csviri pushed a commit that referenced this pull request Oct 21, 2022
@metacosm @csviri
refactor: deleteBulkResource -> deleteTargetResource (#1544)
31502ce 
* refactor: deleteBulkResource -> deleteTargetResource

* refactor: remove now unneeded class

* refactor: deleteBulkResourcesIfRequired -> deleteExtraResources

* fix: javadoc
csviri pushed a commit that referenced this pull request Oct 25, 2022
@metacosm @csviri
refactor: deleteBulkResource -> deleteTargetResource (#1544)
72158d9 
* refactor: deleteBulkResource -> deleteTargetResource

* refactor: remove now unneeded class

* refactor: deleteBulkResourcesIfRequired -> deleteExtraResources

* fix: javadoc
csviri pushed a commit that referenced this pull request Oct 28, 2022
@metacosm @csviri
refactor: deleteBulkResource -> deleteTargetResource (#1544)
3bd8333 
* refactor: deleteBulkResource -> deleteTargetResource

* refactor: remove now unneeded class

* refactor: deleteBulkResourcesIfRequired -> deleteExtraResources

* fix: javadoc
csviri pushed a commit that referenced this pull request Oct 31, 2022
@metacosm @csviri
refactor: deleteBulkResource -> deleteTargetResource (#1544)
e83772f 
* refactor: deleteBulkResource -> deleteTargetResource

* refactor: remove now unneeded class

* refactor: deleteBulkResourcesIfRequired -> deleteExtraResources

* fix: javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metacosm @csviri