Skip to content

fix: avoid computing alternate value if not needed in Optionals #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2022
Merged

fix: avoid computing alternate value if not needed in Optionals #1537

merged 1 commit into from
Oct 12, 2022

Conversation

metacosm
Copy link
Collaborator

Fixes #1535

@metacosm metacosm self-assigned this Oct 12, 2022
@metacosm metacosm requested a review from csviri October 12, 2022 10:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

37.5% 37.5% Coverage
0.0% 0.0% Duplication

csviri
csviri approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm metacosm merged commit a9082e2 into main Oct 12, 2022
@metacosm metacosm deleted the fix1535 branch October 12, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AbstractDependentResource reconciles two times on update
2 participants
@metacosm @csviri