Skip to content

Support PrimaryToSecondaryMapper in KubernetesDependnetResource #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csviri opened this issue Jan 5, 2023 · 3 comments · Fixed by #1744
Closed

Support PrimaryToSecondaryMapper in KubernetesDependnetResource #1703

csviri opened this issue Jan 5, 2023 · 3 comments · Fixed by #1744
Assignees
@csviri
Labels
dependent-resources-epic
Milestone
4.3

Comments

@csviri
Copy link
Collaborator

csviri commented Jan 5, 2023 •
edited
Loading

In similar way the SecondaryToPrimaryMapper is supported.

see: https://github.com/java-operator-sdk/java-operator-sdk/blob/3e4723a36f6a08639b7d7903ae4847a63de20e42/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java#L87-L89
@csviri csviri added this to the 4.3 milestone Jan 5, 2023
@csviri csviri self-assigned this Jan 5, 2023
@csviri
Copy link
Collaborator Author

csviri commented Jan 5, 2023

Now I'm thinking if this makes sense for dependent resources. PrimaryToSecondaryMapper is only needed if there is a many-to-one or many-to-many relationship between the secondary and primary resource. That mean those resources are usually not managed, just serves as an input. So there is no need to create a dependent resource for them, rather that would be just an informer to have them cached.

Will close this issue until, we receive a concrete use-case / request for this.

@csviri csviri closed this as completed Jan 5, 2023
@csviri csviri mentioned this issue Jan 13, 2023
Closed
@csviri
Copy link
Collaborator Author

csviri commented Jan 13, 2023 •
edited
Loading

Note that this might be beneficial in the case if some want to add a reconcile pre-condition on a read only resource. So I'm reopening this issue.

@csviri csviri reopened this Jan 13, 2023
@csviri csviri linked a pull request Jan 30, 2023 that will close this issue
Primary to seconday dr informer sample #1744
Merged
@csviri
Copy link
Collaborator Author

csviri commented Jan 30, 2023

Added sample how this is possible to do.

@csviri csviri closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csviri csviri

Labels
dependent-resources-epic
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Primary to seconday dr informer sample operator-framework/java-operator-sdk
1 participant
@csviri