Bump kubebuilder to 3.15.0 (with merge conflicts resolved) #90
Conversation
|
@acornett21 / @joelanford can you help fix the test failures? |
openshift-merge-robot
added
the
needs-rebase
|
@Neo2308 We can probably drop this right? Since we need to go to kubebuilder v4 to get k8s 1.30, correct? |
|
@acornett21 we could drop this, but since this already has some of the major changes that are needed when moving to kubebuilder v4, it would be easier to get this merged and make the extra changes on top of it. |
Signed-off-by: Joe Lanford <[email protected]>
Neo2308
force-pushed
the
bump-kubebuilder
branch
from
fd34f39 to
311f40b
Compare
openshift-merge-robot
removed
the
needs-rebase
acornett21
left a comment
acornett21
left a comment
There was a problem hiding this comment.
Just a couple of small comments.
|
I'm pretty sure @Neo2308's responses to the review questions are correct, but my memory is fuzzy. I had some conversations with @camilamacedo86 in the upstream kubebuilder channel after I made my original PR and I think further changes came in 3.15.1 and 4.x releases. To be honest, I've long since evicted this from my cache, and I don't have time right now to load all this back in. |
@joelanford further changes for sure, we are trying to layer them on in smaller chunks. Thanks for the reply. |
4 participants
Contains the changes from the below PR along with merge conflicts resolved.
Ref: #77