update gpu block size based on xattn #2764
Draft
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const char* env_p = std::getenv("OV_GPU_XATTN_BLOCK_SIZE"); | ||
| size_t gpu_block_size = 256; | ||
| if (env_p != nullptr && std::stoi(env_p) == 1) { | ||
| gpu_block_size = 16; |
There was a problem hiding this comment.
This ticket https://jira.devtools.intel.com/browse/CVS-161326 makes genai get kv cache actual precision from plugin after compiling. Can you please refer it to make genai get kv_block_size from plugin too?
There was a problem hiding this comment.
Thanks for the comment! Have updated related code, would you mind taking a look again ?
rnwang04
force-pushed
the
pa_block_xattn
branch
from
5a146f4 to
e8311d7
Compare
rnwang04
force-pushed
the
pa_block_xattn
branch
from
e8311d7 to
eded411
Compare
rnwang04
force-pushed
the
pa_block_xattn
branch
from
b56c1c5 to
ac7a454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work with openvinotoolkit/openvino#32064