Student dashboard #108
Merged
Student dashboard #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanstitt
force-pushed
the
student-dashboard
branch
8 times, most recently
from
04ef516 to
efb42f1
Compare
|
As a skeleton commit what's still WIP (can you add the TODO's to the PR description)? I think this would be great to pull in for @Fredasaurus / @dak to tweak. |
nathanstitt
force-pushed
the
student-dashboard
branch
4 times, most recently
from
57a13cd to
fb99319
Compare
This was referenced Apr 25, 2015
Merged
nathanstitt
force-pushed
the
student-dashboard
branch
3 times, most recently
from
1bc7966 to
5b202b4
Compare
|
|
||
| render: -> | ||
| content = @props.children or "No events this week" | ||
| <BS.Panel header={@props.title}> |
There was a problem hiding this comment.
can you add className="empty" to the panel instead of the inner div? That way the whole panel could be hidden.
This way we can hide the panel all together if we choose to
This changes the Time component to default to "short" display, which is defined as: MMM DD, YYYY
nathanstitt
pushed a commit
that referenced
this pull request
Aug 1, 2016
progress no longer doubles the current page, clean up progress view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO in future PRs:
alertcalls.alert. It seems like this maybe could render the reading, but not sure of the best approach to take there.