Core 1382: Book tile link should use portal path to details page #2798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
core-1382-book-tile-links-on-portal-page
branch
from
615a7fd to
6dde5f0
Compare
RoyEJohnson
commented
Nov 25, 2025
| const EXTERNAL = /^([a-z]+:)/; | ||
| const ABSOLUTE_OPENSTAX = new RegExp( | ||
| `(?:https?://openstax.org|${window.location.origin})(?!/(?:books|accounts|oxauth|blog-feed|documents)/)` | ||
| `(?:https?://openstax.org|${window.location.origin})(?!/(?:(?:.*/)?books|accounts|oxauth|blog-feed|documents)/)` |
Contributor
Author
There was a problem hiding this comment.
Rex books links may have a portal prefix
RoyEJohnson
commented
Nov 25, 2025
| className='btn go-to' | ||
| {...(track ? {'data-track': track} : {})} | ||
| data-variant={lookupVariant(variant)} | ||
| data-local="true" |
Contributor
Author
There was a problem hiding this comment.
This causes the Rex link to open in the current tab even though it's an "external" link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-1382
This is live on Staging. I wasn't expecting it to open in a new tab, but it is programmed so that portal base page links always do.