Add tabbable option to Highlight object #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
add-tabbable-option
branch
from
4a13636 to
0a3a09b
Compare
RoyEJohnson
force-pushed
the
add-tabbable-option
branch
3 times, most recently
from
109c805 to
fdc33f5
Compare
TomWoodward
requested changes
Feb 1, 2024
Member
TomWoodward
left a comment
TomWoodward
left a comment
There was a problem hiding this comment.
don't commit the dist folder
RoyEJohnson
force-pushed
the
add-tabbable-option
branch
2 times, most recently
from
e229050 to
b4f8af0
Compare
TomWoodward
requested changes
Feb 2, 2024
Member
TomWoodward
left a comment
TomWoodward
left a comment
There was a problem hiding this comment.
can you update one of the injectHighlightWrappers specs to test adding the tabindex
otherwise this looks fine
TomWoodward
approved these changes
Feb 14, 2024
Default tabbable to true Update snapshots
RoyEJohnson
force-pushed
the
add-tabbable-option
branch
from
c66c14c to
7cb7c70
Compare
RoyEJohnson
force-pushed
the
add-tabbable-option
branch
from
7cb7c70 to
a9037c3
Compare
RoyEJohnson
force-pushed
the
add-tabbable-option
branch
from
a9037c3 to
bd17f1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://github.com/openstax/unified/issues/2750