Skip to content

Conversation

@yutaro-sakamoto
Copy link
Contributor

@yutaro-sakamoto yutaro-sakamoto commented Aug 26, 2025

  • Make sure to unlock previously locked records when executing READ, WRITE, REWRITE, DELETE and CLOSE.
  • Add extra conditions to SQL statements that unlock records in order not to unlock records locked by other processes.
  • Add extra tests of unlocking records.

@yutaro-sakamoto yutaro-sakamoto marked this pull request as ready for review August 27, 2025 05:58
Copilot AI review requested due to automatic review settings August 27, 2025 05:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements functionality to unlock previously locked records when executing READ, WRITE, REWRITE, DELETE and CLOSE operations in indexed file handling. The change addresses record locking behavior in COBOL file operations to ensure proper cleanup of locks.

  • Adds a new postProcess() method to handle unlocking operations after file operations complete
  • Updates lock management SQL queries to include process UUID validation for safer unlocking
  • Integrates lock cleanup into various file operation methods (READ, WRITE, REWRITE, DELETE)

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/indexed-lock.src/release-lock.at Adds comprehensive test cases for unlock behavior during READ and REWRITE operations
libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/file/CobolIndexedFile.java Implements core unlocking logic with SQL query updates and postProcess integration
libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/file/CobolFile.java Adds postProcess framework and integrates unlock calls into file operation methods

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yutaro-sakamoto yutaro-sakamoto merged commit b7a33f2 into opensourcecobol:develop Aug 28, 2025
145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants