-
Notifications
You must be signed in to change notification settings - Fork 38
Unlock previously locked records when executing READ, WRITE, REWRITE, DELETE and CLOSE #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlock previously locked records when executing READ, WRITE, REWRITE, DELETE and CLOSE #699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements functionality to unlock previously locked records when executing READ, WRITE, REWRITE, DELETE and CLOSE operations in indexed file handling. The change addresses record locking behavior in COBOL file operations to ensure proper cleanup of locks.
- Adds a new
postProcess()method to handle unlocking operations after file operations complete - Updates lock management SQL queries to include process UUID validation for safer unlocking
- Integrates lock cleanup into various file operation methods (READ, WRITE, REWRITE, DELETE)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/indexed-lock.src/release-lock.at | Adds comprehensive test cases for unlock behavior during READ and REWRITE operations |
| libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/file/CobolIndexedFile.java | Implements core unlocking logic with SQL query updates and postProcess integration |
| libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/file/CobolFile.java | Adds postProcess framework and integrates unlock calls into file operation methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/file/CobolFile.java
Outdated
Show resolved
Hide resolved
libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/file/CobolFile.java
Outdated
Show resolved
Hide resolved
…ile/CobolFile.java Co-authored-by: Copilot <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.