fix!: Runs should trigger materialization result #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug was found that if a plan was empty. Also adds more metadata for each asset
ravenac95
commented
Aug 18, 2025
1 task
ravenac95
force-pushed
the
ravenac95/run-should-trigger-materialization-result
branch
from
e371e61 to
863ebac
Compare
IcaroG
approved these changes
Aug 18, 2025
Comment on lines
+257
to
+262
| if model_name_for_notification in self._non_model_names: | ||
| self._current_index += 1 | ||
| self.logger.debug( | ||
| f"skipping non-model snapshot {model_name_for_notification}" | ||
| ) | ||
| continue |
Member
Author
There was a problem hiding this comment.
Ugh. Sadly the bug was a bit multi-faceted.
This was part of the issue, but generally, the bug was that we created a queue of things to be reported as materialized. We did this because if you enable subsetting of the dagster asset you need to avoid out of order AssetMaterialization objects being yielded from the asset. So the logic to initialize that set of things was all funky. The core of the problems were in the Materialization tracker, which maybe could require further rethinking, but I think we now get a fuller picture of what's happening with these changes.
ravenac95
deleted the
ravenac95/run-should-trigger-materialization-result
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of opensource-observer/oso#4757
The follow on would be to update the dependency in the oso repo.