[release-4.20] OCPBUGS-66204: Add option abortonclose to HAProxy configuration template

[alebedev87]

Manual cherry-pick of #688.

The change will add the ROUTER_ABORT_ON_CLOSE environment variable to enable option abortonclose in HAProxy ( see doc) to be able to stop processing TLS handshakes or drop pending HTTP requests if a client closes a connection.

In this way HAProxy will drop prematurely closed requests pending in queues, avoiding unnecessary computational resource usage and so performance degradation too.

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-66204, which is invalid:

• expected dependent Jira Issue OCPBUGS-60885 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of #688.

The change will add the ROUTER_ABORT_ON_CLOSE environment variable to enable option abortonclose in HAProxy ( see doc) to be able to stop processing TLS handshakes or drop pending HTTP requests if a client closes a connection.

In this way HAProxy will drop prematurely closed requests pending in queues, avoiding unnecessary computational resource usage and so performance degradation too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[lihongan]

/jira refresh

[openshift-ci-robot]

@lihongan: This pull request references Jira Issue OCPBUGS-66204, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.z) matches configured target version for branch (4.20.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-60885 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-60885 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
• bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lihongan]

/label qe-approved
/verified by @lihongan

pre-merge tested and passed

$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.20.0-0-2025-12-02-042753-test-ci-ln-lzilb2t-latest   True        False         96m     Cluster version is 4.20.0-0-2025-12-02-042753-test-ci-ln-lzilb2t-latest

$ oc -n openshift-ingress exec router-default-79779595d7-p5zpw -- grep abort haproxy-config.template -C1
  {{- if isTrue (env "ROUTER_ABORT_ON_CLOSE") }}
  option abortonclose
  {{- end }}

$ oc -n openshift-ingress exec router-default-79779595d7-p5zpw -- grep abort haproxy.config
command terminated with exit code 1

// scale down CVO and CIO and set Env in deploy/router-default as
$ oc -n openshift-ingress get deployment/router-default -oyaml | grep ABORT -A1
        - name: ROUTER_ABORT_ON_CLOSE
          value: "true"

$ oc -n openshift-ingress exec router-default-548d757cc7-ds2b4 -- grep abort haproxy.config -C1
  timeout tunnel 1h
  option abortonclose

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-66204, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.z) matches configured target version for branch (4.20.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-60885 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-60885 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
• bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Manual cherry-pick of #688.

The change will add the ROUTER_ABORT_ON_CLOSE environment variable to enable option abortonclose in HAProxy ( see doc) to be able to stop processing TLS handshakes or drop pending HTTP requests if a client closes a connection.

In this way HAProxy will drop prematurely closed requests pending in queues, avoiding unnecessary computational resource usage and so performance degradation too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@lihongan: This PR has been marked as verified by @lihongan.

Details

In response to this:

/label qe-approved
/verified by @lihongan

pre-merge tested and passed

$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.20.0-0-2025-12-02-042753-test-ci-ln-lzilb2t-latest   True        False         96m     Cluster version is 4.20.0-0-2025-12-02-042753-test-ci-ln-lzilb2t-latest

$ oc -n openshift-ingress exec router-default-79779595d7-p5zpw -- grep abort haproxy-config.template -C1
 {{- if isTrue (env "ROUTER_ABORT_ON_CLOSE") }}
 option abortonclose
 {{- end }}

$ oc -n openshift-ingress exec router-default-79779595d7-p5zpw -- grep abort haproxy.config
command terminated with exit code 1

// scale down CVO and CIO and set Env in deploy/router-default as
$ oc -n openshift-ingress get deployment/router-default -oyaml | grep ABORT -A1
       - name: ROUTER_ABORT_ON_CLOSE
         value: "true"

$ oc -n openshift-ingress exec router-default-548d757cc7-ds2b4 -- grep abort haproxy.config -C1
 timeout tunnel 1h
 option abortonclose

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[alebedev87]

/assign @davidesalerno

[davidesalerno]

/lgtm

[davidesalerno]

/approve

[Miciah]

This is a low-risk change that does not cause any functional change unless the new ROUTER_ABORT_ON_CLOSE environment variable is set.

/label backport-risk-assessed

[Miciah]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidesalerno, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@alebedev87: Jira Issue OCPBUGS-66204: Some pull requests linked via external trackers have merged:

• openshift/api#2609
• openshift/router#695

The following pull request, linked via external tracker, has not merged:

• openshift/cluster-ingress-operator#1314 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-66204 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

Manual cherry-pick of #688.

The change will add the ROUTER_ABORT_ON_CLOSE environment variable to enable option abortonclose in HAProxy ( see doc) to be able to stop processing TLS handshakes or drop pending HTTP requests if a client closes a connection.

In this way HAProxy will drop prematurely closed requests pending in queues, avoiding unnecessary computational resource usage and so performance degradation too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[alebedev87]

/cherry-pick release-4.19

[openshift-cherrypick-robot]

@alebedev87: new pull request created: #701

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-robot]

Fix included in accepted release 4.20.0-0.nightly-2025-12-09-061327