OCPBUGS-12297: OCPBUGS-12325: Increase memory limits for storage unit tests #38661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jsafrane wants to merge 1 commit into openshift:master from jsafrane:bump-memory

Contributor

jsafrane commented Apr 24, 2023

These two unit / verify tests were killed by OOM after bump to go 1.20:

cc @openshift/storage

Contributor Author

jsafrane commented Apr 24, 2023

/pj-rehearse

openshift-ci bot requested review from bertinatto and dobsonj

April 24, 2023 13:05

Contributor

openshift-ci bot commented Apr 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/aws-ebs-csi-driver/OWNERS~~ [jsafrane]
~~ci-operator/config/openshift/ibm-vpc-block-csi-driver/OWNERS~~ [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label

jsafrane changed the title ~~Increase memory limits for storage unit tests~~ OCPBUGS-12297: OCPBUGS-12325: Increase memory limits for storage unit tests

openshift-ci-robot added jira/valid-reference jira/invalid-bug labels

Contributor

openshift-ci-robot commented Apr 24, 2023

@jsafrane: This pull request references Jira Issue OCPBUGS-12297, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

These two unit / verify tests were killed by OOM after bump to go 1.20:

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_aws-ebs-csi-driver/220/pull-ci-openshift-aws-ebs-csi-driver-master-verify/1650461627809533952

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_ibm-vpc-block-csi-driver/36/pull-ci-openshift-ibm-vpc-block-csi-driver-master-verify/1650474443207610368

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor Author

jsafrane commented Apr 24, 2023

/jira refresh

openshift-ci-robot added jira/valid-bug bugzilla/valid-bug and removed jira/invalid-bug labels

Contributor

openshift-ci-robot commented Apr 24, 2023

@jsafrane: This pull request references Jira Issue OCPBUGS-12297, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane mentioned this pull request

Updating ose-ibm-vpc-block-csi-driver images to be consistent with ART openshift/ibm-vpc-block-csi-driver#36

Merged

Contributor Author

jsafrane commented Apr 25, 2023

/pj-rehearse pull-ci-openshift-ibm-vpc-block-csi-driver-master-verify

Contributor Author

jsafrane commented Apr 25, 2023

/pj-rehearse

jsafrane force-pushed the bump-memory branch from ab86e32 to ce2fe81 Compare

April 25, 2023 12:22

Contributor Author

jsafrane commented Apr 25, 2023

/pj-rehearse pull-ci-openshift-ibm-vpc-block-csi-driver-master-verify

jsafrane force-pushed the bump-memory branch from ce2fe81 to 661cb5a Compare

April 25, 2023 12:49

Contributor Author

jsafrane commented Apr 25, 2023

/pj-rehearse pull-ci-openshift-ibm-vpc-block-csi-driver-master-verify

1 similar comment

Contributor Author

jsafrane commented Apr 25, 2023

/pj-rehearse pull-ci-openshift-ibm-vpc-block-csi-driver-master-verify


          Increase memory limits for storage unit tests

6ec867e

These two unit / verify tests were killed by OOM after bump to go 1.20.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_aws-ebs-csi-driver/220/pull-ci-openshift-aws-ebs-csi-driver-master-verify/1650461627809533952
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_ibm-vpc-block-csi-driver/36/pull-ci-openshift-ibm-vpc-block-csi-driver-master-verify/1650474443207610368

jsafrane force-pushed the bump-memory branch from 661cb5a to 6ec867e Compare

April 25, 2023 15:23

Contributor Author

jsafrane commented Apr 25, 2023

/pj-rehearse pull-ci-openshift-ibm-vpc-block-csi-driver-master-verify

Contributor

openshift-ci-robot commented Apr 25, 2023

[REHEARSALNOTIFIER]
@jsafrane: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-aws-ebs-csi-driver-master-e2e-aws-csi	openshift/aws-ebs-csi-driver	presubmit	Ci-operator config changed
pull-ci-openshift-aws-ebs-csi-driver-master-e2e-aws-csi-extended	openshift/aws-ebs-csi-driver	presubmit	Ci-operator config changed
pull-ci-openshift-aws-ebs-csi-driver-master-images	openshift/aws-ebs-csi-driver	presubmit	Ci-operator config changed
pull-ci-openshift-aws-ebs-csi-driver-master-unit	openshift/aws-ebs-csi-driver	presubmit	Ci-operator config changed
pull-ci-openshift-aws-ebs-csi-driver-master-verify	openshift/aws-ebs-csi-driver	presubmit	Ci-operator config changed
pull-ci-openshift-aws-ebs-csi-driver-master-verify-deps	openshift/aws-ebs-csi-driver	presubmit	Ci-operator config changed
pull-ci-openshift-ibm-vpc-block-csi-driver-master-e2e-ibmcloud-csi	openshift/ibm-vpc-block-csi-driver	presubmit	Ci-operator config changed
pull-ci-openshift-ibm-vpc-block-csi-driver-master-images	openshift/ibm-vpc-block-csi-driver	presubmit	Ci-operator config changed
pull-ci-openshift-ibm-vpc-block-csi-driver-master-unit	openshift/ibm-vpc-block-csi-driver	presubmit	Ci-operator config changed
pull-ci-openshift-ibm-vpc-block-csi-driver-master-verify	openshift/ibm-vpc-block-csi-driver	presubmit	Ci-operator config changed
pull-ci-openshift-ibm-vpc-block-csi-driver-master-verify-deps	openshift/ibm-vpc-block-csi-driver	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Contributor

openshift-ci bot commented Apr 25, 2023

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/ibm-vpc-block-csi-driver/master/verify	`6ec867e`	link	unknown	`/pj-rehearse pull-ci-openshift-ibm-vpc-block-csi-driver-master-verify`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor Author

jsafrane commented Apr 26, 2023

/close
The CSI drivers uses golangci-lint, which is not compatible with go 1.20, golangci/golangci-lint#3538 (comment)
I am rebasing the drivers to use a newer golint instead.

openshift-ci bot closed this

Contributor

openshift-ci bot commented Apr 26, 2023

@jsafrane: Closed this PR.

In response to this:

/close
The CSI drivers uses golangci-lint, which is not compatible with go 1.20, golangci/golangci-lint#3538 (comment)
I am rebasing the drivers to use a newer golint instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

openshift-ci-robot commented Apr 26, 2023

@jsafrane: This pull request references Jira Issue OCPBUGS-12297. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

These two unit / verify tests were killed by OOM after bump to go 1.20:

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_aws-ebs-csi-driver/220/pull-ci-openshift-aws-ebs-csi-driver-master-verify/1650461627809533952

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_ibm-vpc-block-csi-driver/36/pull-ci-openshift-ibm-vpc-block-csi-driver-master-verify/1650474443207610368

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved bugzilla/valid-bug jira/valid-bug jira/valid-reference