OPRUN-4056: [OTE] Migrate preflight checks from openshift/origin #423
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
camilamacedo86
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@camilamacedo86: This pull request references OPRUN-4056 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -1,4 +1,64 @@ | |||
| [ | |||
| { | |||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {services} are not specified", | |||
There was a problem hiding this comment.
| "environmentSelector": {} | ||
| }, | ||
| { | ||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {create} verb is not specified", |
There was a problem hiding this comment.
| "environmentSelector": {} | ||
| }, | ||
| { | ||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {ClusterRoleBindings} are not specified", |
There was a problem hiding this comment.
| "environmentSelector": {} | ||
| }, | ||
| { | ||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {ConfigMap:resourceNames} are not all specified", |
There was a problem hiding this comment.
| "environmentSelector": {} | ||
| }, | ||
| { | ||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {clusterextension/finalizer} is not specified", |
There was a problem hiding this comment.
| "environmentSelector": {} | ||
| }, | ||
| { | ||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {escalate, bind} is not specified", |
There was a problem hiding this comment.
|
@camilamacedo86: This pull request references OPRUN-4056 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws-techpreview |
openshift-merge-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
migrate-preflight
branch
from
ba99815 to
daa1fc3
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/hold We should wait for the new branch cut before proceeding. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm please note: the merge is held because of cutting branch. so, better to wait for that. |
openshift-merge-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
migrate-preflight
branch
from
daa1fc3 to
19d9da6
Compare
openshift-merge-robot
removed
the
needs-rebase
camilamacedo86
force-pushed
the
migrate-preflight
branch
from
205878b to
9794b3f
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest-required |
There was a problem hiding this comment.
I really think we should have scenario has an enum. Right now we have magic numbers 0 through 5.
|
Again... why are techpreview tests failing? I've seen this elsewhere... so I'm not sure it's related to this PR. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Hi @tmshort
See that is how it is today, we can try to improve after |
|
Hi @tmshort
The changes of this PR are not in the payload. |
|
/test openshift-e2e-aws-techpreview |
|
/test openshift-e2e-aws-techpreview |
|
/payload-aggregate-with-prs periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm 5 |
|
@camilamacedo86: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-aggregate-with-prs periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm |
|
@camilamacedo86: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 5 |
camilamacedo86
force-pushed
the
migrate-preflight
branch
from
9794b3f to
c52ba5a
Compare
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 10 |
|
@camilamacedo86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d378ce90-7a1f-11f0-8bf6-588568da3b08-0 |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 10 |
|
@camilamacedo86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cab853e0-7a77-11f0-80dc-0a55ab730901-0 |
Migrated OLMv1 operator preflight checks from using external YAML files to defining ClusterRole permissions directly in Go structs. This improves test reliability and simplifies test setup by removing file dependencies. The changes ensure precise replication of original test scenarios, including specific permission omissions for services, create verbs, ClusterRoleBindings, ConfigMap resourceNames, and escalate/bind verbs. Assisted-by: Gemini
camilamacedo86
force-pushed
the
migrate-preflight
branch
from
c52ba5a to
2e69a2c
Compare
|
/test openshift-e2e-aws |
|
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@camilamacedo86: This pull request references OPRUN-4056 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm please note: the merge is held because of cutting branch. so, better to wait for that. |
Migrated OLMv1 operator preflight checks from using external YAML files to defining ClusterRole permissions directly in Go structs. This improves test reliability and simplifies test setup by removing file dependencies.
The changes ensure precise replication of original test scenarios, including specific permission omissions for services, create verbs, ClusterRoleBindings, ConfigMap resourceNames, and escalate/bind verbs.
You can check the PR to delete the migrated tests here : openshift/origin#30074 ( it might help you validate )
Tests: