Skip to content

Conversation

jhradilek
Copy link
Contributor

@jhradilek jhradilek commented May 19, 2025

Version(s): 4.18+

Issue: CNV-62093

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 19, 2025

@jhradilek: This pull request references CNV-62093 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.18+

Issue: CNV-62093

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 19, 2025
@ocpdocs-previewbot
Copy link

🤖 Mon May 19 17:40:34 - Prow CI generated the docs preview:
https://93554--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

Copy link

openshift-ci bot commented May 19, 2025

@jhradilek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhradilek
Copy link
Contributor Author

/label cnv

@openshift-ci openshift-ci bot added the CNV Label for all CNV PRs label May 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 19, 2025

@jhradilek: This pull request references CNV-62093 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.18+

Issue: CNV-62093

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhradilek
Copy link
Contributor Author

This change does not affect the technical accuracy, nor does it affect any existing links. Because of that, QE review is not needed. I manually updated the preview links to point directly to all 35 changed subsections.

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 19, 2025
@ShaunaDiaz ShaunaDiaz added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 20, 2025
@ShaunaDiaz ShaunaDiaz changed the title CNV-62093: Updat all titles to use "CLI" instead of "command line" CNV-62093: Update all titles to use "CLI" instead of "command line" May 20, 2025
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good, thanks for the many links to each section!

Beyond the headlines, I do see

  1. that several procedures do not include installing oc as a prereq and they probably should;
  2. many of these say "command line" in the intro text instead of "command-line interface", so that should be updated.
    Perhaps you can address these details in two subsequent PRs when you are next in the improvements neighborhood?

@ShaunaDiaz ShaunaDiaz added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 20, 2025
@jhradilek
Copy link
Contributor Author

These all look good, thanks for the many links to each section!

Beyond the headlines, I do see

  1. that several procedures do not include installing oc as a prereq and they probably should;
  2. many of these say "command line" in the intro text instead of "command-line interface", so that should be updated. Perhaps you can address these details in two subsequent PRs when you are next in the improvements neighborhood?

Thank you, and great observation. I am going to address these in separate PRs as you suggest.

@jhradilek
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 20, 2025
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone May 20, 2025
@ShaunaDiaz ShaunaDiaz added branch/enterprise-4.18 branch/enterprise-4.19 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 20, 2025
@ShaunaDiaz ShaunaDiaz merged commit 5dbf1b1 into openshift:main May 20, 2025
2 checks passed
@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.19

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #93589

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: #93554 failed to apply on top of branch "enterprise-4.18":

Applying: CNV-62093: Updated all titles to use CLI instead of command line.
Using index info to reconstruct a base tree...
A	modules/virt-enabling-disabling-vm-delete-protection-cli.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/virt-enabling-disabling-vm-delete-protection-cli.adoc deleted in HEAD and modified in CNV-62093: Updated all titles to use CLI instead of command line.. Version CNV-62093: Updated all titles to use CLI instead of command line. of modules/virt-enabling-disabling-vm-delete-protection-cli.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-62093: Updated all titles to use CLI instead of command line.

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShaunaDiaz
Copy link
Contributor

@jhradilek Ah darn, the 4.18 cherry pick failed. If you want to fix it with a manual pick and ping me, I can merge for you when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.18 branch/enterprise-4.19 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants