-
Notifications
You must be signed in to change notification settings - Fork 1.8k
CNV-62093: Update all titles to use "CLI" instead of "command line" #93554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jhradilek: This pull request references CNV-62093 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Mon May 19 17:40:34 - Prow CI generated the docs preview: |
@jhradilek: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label cnv |
This change does not affect the technical accuracy, nor does it affect any existing links. Because of that, QE review is not needed. I manually updated the preview links to point directly to all 35 changed subsections. /label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all look good, thanks for the many links to each section!
Beyond the headlines, I do see
- that several procedures do not include installing
oc
as a prereq and they probably should; - many of these say "command line" in the intro text instead of "command-line interface", so that should be updated.
Perhaps you can address these details in two subsequent PRs when you are next in the improvements neighborhood?
Thank you, and great observation. I am going to address these in separate PRs as you suggest. |
/label merge-review-needed |
/cherrypick enterprise-4.19 |
/cherrypick enterprise-4.18 |
@ShaunaDiaz: new pull request created: #93589 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: #93554 failed to apply on top of branch "enterprise-4.18":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jhradilek Ah darn, the 4.18 cherry pick failed. If you want to fix it with a manual pick and ping me, I can merge for you when ready. |
Version(s): 4.18+
Issue: CNV-62093
Link to docs preview:
QE review:
Additional information: