Skip to content

Conversation

max-cx
Copy link
Contributor

@max-cx max-cx commented May 19, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 19, 2025

@max-cx: This pull request references OBSDOCS-1629 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 19, 2025

@max-cx: This pull request references OBSDOCS-1629 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): main, 4.19

Issue: https://issues.redhat.com/browse/OBSDOCS-1629

Link to docs preview:

QE review: N/A

Additional information: Fix for #92944

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 19, 2025

🤖 Tue May 27 22:59:18 - Prow CI generated the docs preview:
https://93526--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 19, 2025

@max-cx: This pull request references OBSDOCS-1629 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): main, 4.19

Issue: https://issues.redhat.com/browse/OBSDOCS-1629

Link to docs preview:

QE review: N/A

Additional information: Fix for #92944

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 19, 2025
@max-cx max-cx force-pushed the OBSDOCS-1629fix branch 5 times, most recently from 855c570 to 87b5e31 Compare May 20, 2025 19:10
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 26, 2025
@max-cx
Copy link
Contributor Author

max-cx commented May 27, 2025

/label peer-review needed

@max-cx max-cx force-pushed the OBSDOCS-1629fix branch 2 times, most recently from 820033c to 798b1d7 Compare May 27, 2025 22:51
@max-cx
Copy link
Contributor Author

max-cx commented May 27, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 27, 2025
Copy link

openshift-ci bot commented May 27, 2025

@max-cx: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 28, 2025
Copy link

openshift-ci bot commented May 28, 2025

@max-cx: Those labels are not set on the issue: merge-review-needed

In response to this:

/remove-label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GroceryBoyJr
Copy link
Contributor

/remove-label merge-review-needed
/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 28, 2025
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 28, 2025
@GroceryBoyJr
Copy link
Contributor

@max-cx I had to remove the merge-review-needed, per our process, and didn't add it back in (per our process). I don't mean to cause inconvenience! Please, just add the label back in when you are ready.

@max-cx
Copy link
Contributor Author

max-cx commented May 29, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 29, 2025
@michaelryanpeter
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 29, 2025
@michaelryanpeter michaelryanpeter added this to the Planned for 4.19 GA milestone May 29, 2025
@michaelryanpeter
Copy link
Contributor

LGTM

There has been some debate as to whether or not to have the include statement above the h1 for assemblies that don't need it (Slack thread). Currently, our guidelines state to use it when you need it (first assembly in a section if that assembly has an attribute). The rule remains in place due to a bug in the asciidoc VS code extension.

Since this is valid asciidoc, isn't customer-facing, and has limited impact, I don't think it is worth blocking a merge. I only mention it for context/awareness. I'm not sure if it is worth following up in another PR unless something breaks. Please double check after everything is published on d.r.c.

@michaelryanpeter michaelryanpeter merged commit 9d716ce into openshift:main May 29, 2025
2 checks passed
@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@michaelryanpeter: new pull request created: #93963

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants