-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-1629: Fix #93526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSDOCS-1629: Fix #93526
Conversation
@max-cx: This pull request references OBSDOCS-1629 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@max-cx: This pull request references OBSDOCS-1629 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Tue May 27 22:59:18 - Prow CI generated the docs preview: |
@max-cx: This pull request references OBSDOCS-1629 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
855c570
to
87b5e31
Compare
/label peer-review needed |
820033c
to
798b1d7
Compare
/label peer-review-needed |
@max-cx: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@max-cx: Those labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/remove-label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/label peer-review-done |
@max-cx I had to remove the merge-review-needed, per our process, and didn't add it back in (per our process). I don't mean to cause inconvenience! Please, just add the label back in when you are ready. |
/label merge-review-needed |
/label merge-review-in-progress |
LGTM There has been some debate as to whether or not to have the include statement above the h1 for assemblies that don't need it (Slack thread). Currently, our guidelines state to use it when you need it (first assembly in a section if that assembly has an attribute). The rule remains in place due to a bug in the asciidoc VS code extension. Since this is valid asciidoc, isn't customer-facing, and has limited impact, I don't think it is worth blocking a merge. I only mention it for context/awareness. I'm not sure if it is worth following up in another PR unless something breaks. Please double check after everything is published on d.r.c. |
/cherrypick enterprise-4.19 |
@michaelryanpeter: new pull request created: #93963 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
main
,4.19
Issue: https://issues.redhat.com/browse/OBSDOCS-1629
Link to docs preview:
QE review: N/A
Additional information: Fix for #92944