Skip to content

OSDOCS-13196 - Virtual Storage Management - Clarify S3 #92903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2025
Merged

OSDOCS-13196 - Virtual Storage Management - Clarify S3 #92903

merged 1 commit into from
Jul 10, 2025

Conversation

eohartman
Copy link
Contributor

@eohartman eohartman commented May 2, 2025 •
edited
Loading

Version(s):
4.18+

Issue:
OSDOCS-13196

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 2, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 2, 2025 •
edited
Loading

🤖 Thu Jul 10 18:33:41 - Prow CI generated the docs preview:

https://92903--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_architecture/rosa_policy_service_definition/rosa-policy-responsibility-matrix.html
https://92903--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_architecture/rosa_policy_service_definition/rosa-policy-responsibility-matrix.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed May 2, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed May 2, 2025
View reviewed changes
@eohartman eohartman force-pushed the osdocs-13196-4 branch 2 times, most recently from 291819b to 24a34ce Compare May 13, 2025 01:44
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed May 13, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 6, 2025
View reviewed changes
@eohartman
Copy link
Contributor Author

@arendej Can you please take a look at this to see if it's good with what we have discussed?

@eohartman eohartman force-pushed the osdocs-13196-4 branch 2 times, most recently from 8481f0a to ad59c5f Compare June 9, 2025 18:35
@eohartman
Copy link
Contributor Author

@rafael-azevedo Can you please take a look and let me know if there are any changes you recommend?

rafael-azevedo
rafael-azevedo reviewed Jun 13, 2025
View reviewed changes
Copy link

@rafael-azevedo rafael-azevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2025
@eohartman
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 20, 2025
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 20, 2025
@lpettyjo lpettyjo self-assigned this Jun 20, 2025
@lpettyjo lpettyjo added this to the Continuous Release milestone Jun 20, 2025
@eohartman
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 8, 2025
@kcarmichael08 kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 8, 2025
kcarmichael08
kcarmichael08 reviewed Jul 8, 2025
View reviewed changes
kcarmichael08
kcarmichael08 reviewed Jul 8, 2025
View reviewed changes
kcarmichael08
kcarmichael08 reviewed Jul 8, 2025
View reviewed changes
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think the footnote style needs to be fixed before merging for consistency and to follow the guidelines.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 10, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 10, 2025

@eohartman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 merged commit 0c1ec5e into openshift:main Jul 10, 2025
2 checks passed
@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.18

@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #95976

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 10, 2025
Merged
@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #95977

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 10, 2025
Merged
@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #95979

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 10, 2025
Merged
@kcarmichael08 kcarmichael08 removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafael-azevedo rafael-azevedo rafael-azevedo left review comments

@kcarmichael08 kcarmichael08 kcarmichael08 left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees

@rafael-azevedo rafael-azevedo

@lpettyjo lpettyjo

Labels
branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@eohartman @ocpdocs-previewbot @kcarmichael08 @openshift-cherrypick-robot @rafael-azevedo @ocpdocs-vale-bot @lpettyjo