-
Notifications
You must be signed in to change notification settings - Fork 125
Bug 2086519: get SCC admission default securityContext.runAsNonRoot to true on positive UIDs #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lt securityContext.runAsNonRoot to true on positive UIDs
@stlaz: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@stlaz: This pull request references Bugzilla bug 2086519, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, s-urbaniak, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/retest-required |
@stlaz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@stlaz: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2086519 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit adds the OS field in the pod specification for the Windows Server deployment used in the network test. This ensures that Windows pods can be identified authoritatively at admission time. As of now the SCC Admission Plugin does not perform any validation for Windows pods, it ignores them. See to openshift/apiserver-library-go#82 Fixes a CI issue introduced by openshift/kubernetes#1290 where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`.
This commit adds the OS field in the pod specification for the Windows Server deployment used in the network test. This ensures that Windows pods can be identified authoritatively at admission time. As of now the SCC Admission Plugin does not perform any validation for Windows pods, it ignores them. See to openshift/apiserver-library-go#82 Fixes a CI issue introduced by openshift/kubernetes#1290 where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`.
This commit adds the OS field in the pod specification for the Windows Server deployment used in the network test. This ensures that Windows pods can be identified authoritatively at admission time. As of now the SCC Admission Plugin does not perform any validation for Windows pods, it ignores them. See to openshift/apiserver-library-go#82 Fixes a CI issue introduced by openshift/kubernetes#1290 where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`.
This commit adds the OS field in the pod specification for the Windows Server deployment used in the network test. This ensures that Windows pods can be identified authoritatively at admission time. As of now the SCC Admission Plugin does not perform any validation for Windows pods, it ignores them. See to openshift/apiserver-library-go#82 Fixes a CI issue introduced by openshift/kubernetes#1290 where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`. (cherry picked from commit 8f7f713)
This commit adds the OS field in the pod specification for the Windows Server deployment used in the network test. This ensures that Windows pods can be identified authoritatively at admission time. As of now the SCC Admission Plugin does not perform any validation for Windows pods, it ignores them. See to openshift/apiserver-library-go#82 Fixes a CI issue introduced by openshift/kubernetes#1290 where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`.
This commit adds the OS field in the pod specification for the Windows Server deployment used in the network test. This ensures that Windows pods can be identified authoritatively at admission time. As of now the SCC Admission Plugin does not perform any validation for Windows pods, it ignores them. See to openshift/apiserver-library-go#82 Fixes a CI issue introduced by openshift/kubernetes#1290 where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`.
/assign @s-urbaniak