Skip to content

Conversation

stlaz
Copy link

@stlaz stlaz commented Jun 17, 2022

/assign @s-urbaniak

…lt securityContext.runAsNonRoot to true on positive UIDs
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 17, 2022
@openshift-ci-robot
Copy link

@stlaz: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and sttts June 17, 2022 08:25
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jun 17, 2022
@stlaz stlaz changed the title get SCC admission default securityContext.runAsNonRoot to true on positive UIDs Bug 2086519: get SCC admission default securityContext.runAsNonRoot to true on positive UIDs Jun 17, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

@stlaz: This pull request references Bugzilla bug 2086519, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2086519: get SCC admission default securityContext.runAsNonRoot to true on positive UIDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@mfojtik
Copy link

mfojtik commented Jun 17, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, s-urbaniak, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
@mfojtik mfojtik removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 17, 2022
@stlaz
Copy link
Author

stlaz commented Jun 17, 2022

/retest-required

@stlaz
Copy link
Author

stlaz commented Jun 17, 2022

/retest-required
the tests seem to be taking a long time

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 25f9057 and 8 for PR HEAD defcb3f in total

@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

@stlaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 284d62a into openshift:master Jun 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

@stlaz: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2086519 has not been moved to the MODIFIED state.

In response to this:

Bug 2086519: get SCC admission default securityContext.runAsNonRoot to true on positive UIDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Jun 23, 2022
This commit adds the OS field in the pod specification for the
Windows Server deployment used in the network test. This ensures that
Windows pods can be identified authoritatively at admission time. As of
now the SCC Admission Plugin does not perform any validation for Windows
pods, it ignores them. See to openshift/apiserver-library-go#82

Fixes a CI issue introduced by openshift/kubernetes#1290
where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`.
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Jun 24, 2022
This commit adds the OS field in the pod specification for the
Windows Server deployment used in the network test. This ensures that
Windows pods can be identified authoritatively at admission time. As of
now the SCC Admission Plugin does not perform any validation for Windows
pods, it ignores them. See to openshift/apiserver-library-go#82

Fixes a CI issue introduced by openshift/kubernetes#1290
where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`.
saifshaikh48 pushed a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Feb 20, 2023
This commit adds the OS field in the pod specification for the
Windows Server deployment used in the network test. This ensures that
Windows pods can be identified authoritatively at admission time. As of
now the SCC Admission Plugin does not perform any validation for Windows
pods, it ignores them. See to openshift/apiserver-library-go#82

Fixes a CI issue introduced by openshift/kubernetes#1290
where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`.
mansikulkarni96 pushed a commit to mansikulkarni96/windows-machine-config-operator that referenced this pull request Feb 27, 2023
This commit adds the OS field in the pod specification for the
Windows Server deployment used in the network test. This ensures that
Windows pods can be identified authoritatively at admission time. As of
now the SCC Admission Plugin does not perform any validation for Windows
pods, it ignores them. See to openshift/apiserver-library-go#82

Fixes a CI issue introduced by openshift/kubernetes#1290
where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`.

(cherry picked from commit 8f7f713)
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/windows-machine-config-operator-1 that referenced this pull request Mar 3, 2023
This commit adds the OS field in the pod specification for the
Windows Server deployment used in the network test. This ensures that
Windows pods can be identified authoritatively at admission time. As of
now the SCC Admission Plugin does not perform any validation for Windows
pods, it ignores them. See to openshift/apiserver-library-go#82

Fixes a CI issue introduced by openshift/kubernetes#1290
where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`.
wgahnagl pushed a commit to wgahnagl/windows-machine-config-operator that referenced this pull request Aug 28, 2023
This commit adds the OS field in the pod specification for the
Windows Server deployment used in the network test. This ensures that
Windows pods can be identified authoritatively at admission time. As of
now the SCC Admission Plugin does not perform any validation for Windows
pods, it ignores them. See to openshift/apiserver-library-go#82

Fixes a CI issue introduced by openshift/kubernetes#1290
where SCC Admission Plugin defaults the `runAsNonRoot` with value `true`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants