OCPCLOUD-3162: conversion: do not set ignition version on AWSMachine

[chrischdi]

Because the following is merged:

• NO-JIRA: Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.9.1 (9c17049) into main cluster-api-provider-aws#569

This is a follow-up to:

• 🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData kubernetes-sigs/cluster-api-provider-aws#5641

Summary by CodeRabbit

• Bug Fixes

  • AWS machine templates and specs no longer force a specific Ignition version; they now rely on the provider’s default, improving compatibility and reducing version-related issues.

• Tests

  • Updated end-to-end and fuzz tests to align with the new Ignition version handling, ensuring stable validation without relying on a hardcoded version.

[openshift-ci-robot]

@chrischdi: This pull request references OCPCLOUD-3162 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Because the following is merged:

• NO-JIRA: Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.9.1 (9c17049) into main cluster-api-provider-aws#569

This is a follow-up to:

• 🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData kubernetes-sigs/cluster-api-provider-aws#5641

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Removed explicit Ignition.Version assignments ("3.4") across AWS-related code paths and tests, leaving version unset to rely on API defaults. Adjustments were made in conversion logic, fuzz tests, and an e2e test template; Ignition.StorageType handling remains unchanged.

Changes

Cohort / File(s)	Summary
Conversion: mapi ➜ capi Ignition defaults pkg/conversion/mapi2capi/aws.go	Stop setting Ignition.Version; initialize Ignition with only StorageType.
Tests: e2e and fuzz alignment e2e/aws_test.go, pkg/conversion/capi2mapi/aws_fuzz_test.go	Remove forced Ignition.Version in AWS test template and fuzzing; keep StorageType initialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

In clouds I hop with gentle might,
I nibbled “3.4” out of sight.
Defaults now breeze through morning air,
Less ink to spill, still running fair.
Thump-thump—my paws approve the way,
Leaner fields to start the day. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly and accurately summarizes the primary change: it indicates this conversion-related PR removes setting the Ignition version on AWSMachine resources, which matches the file changes and PR objectives; including the OCPCLOUD-3162 reference is appropriate for tracking.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between e6b0e94 and 6808502.

📒 Files selected for processing (3)

• e2e/aws_test.go (0 hunks)
• pkg/conversion/capi2mapi/aws_fuzz_test.go (0 hunks)
• pkg/conversion/mapi2capi/aws.go (0 hunks)

💤 Files with no reviewable changes (3)

• e2e/aws_test.go
• pkg/conversion/capi2mapi/aws_fuzz_test.go
• pkg/conversion/mapi2capi/aws.go

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@chrischdi: This pull request references OCPCLOUD-3162 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Because the following is merged:

• NO-JIRA: Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.9.1 (9c17049) into main cluster-api-provider-aws#569

This is a follow-up to:

• 🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData kubernetes-sigs/cluster-api-provider-aws#5641

Summary by CodeRabbit

• Bug Fixes

• AWS machine templates and specs no longer force a specific Ignition version; they now rely on the provider’s default, improving compatibility and reducing version-related issues.

• Tests

• Updated end-to-end and fuzz tests to align with the new Ignition version handling, ensuring stable validation without relying on a hardcoded version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[chrischdi]

/jira sync

[damdo]

/approve
/lgtm

Thanks!

[openshift-ci-robot]

/test remaining-required

Scheduling tests matching the pipeline_run_if_changed parameter:
/test e2e-aws-capi-techpreview
/test e2e-aws-ovn
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-techpreview
/test e2e-aws-ovn-techpreview-upgrade
/test e2e-azure-capi-techpreview
/test e2e-azure-ovn-techpreview
/test e2e-azure-ovn-techpreview-upgrade
/test e2e-gcp-capi-techpreview
/test e2e-gcp-ovn-techpreview
/test e2e-metal3-capi-techpreview
/test e2e-openstack-capi-techpreview
/test e2e-openstack-ovn-techpreview
/test e2e-vsphere-capi-techpreview
/test regression-clusterinfra-aws-ipi-techpreview-capi

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

/hold

Let's prioritize #358 merging before this, as it blocks other PRs

[chrischdi]

/hold cancel

As

• NO-JIRA: use go workspaces #358

is merged

:-)

/retest-required

[damdo]

/test regression-clusterinfra-aws-ipi-techpreview-capi

[chrischdi]

/verified bypass

Small change which should have been catched by e2e on issues. However I anyway created a cluster using clusterbot and this PR and verified:

• the field is not set on AWSMachines anymore 🎉
• the CCAPIO logs did not show anything suspicios

[openshift-ci-robot]

@chrischdi: The verified label has been added.

In response to this:

/verified bypass

Small change which should have been catched by e2e on issues. However I anyway created a cluster using clusterbot and this PR and verified:

• the field is not set on AWSMachines anymore 🎉
• the CCAPIO logs did not show anything suspicios

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a17bce7 and 2 for PR HEAD 6808502 in total

[damdo]

/override ci/prow/e2e-openstack-ovn-techpreview

It is quite borked at the moment, and for sure it is not failing for this AWS specific field. Also the overall CAPI Openstack jobs is passing happily e2e-openstack-capi-techpreview. Overriding..

[openshift-ci]

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-openstack-ovn-techpreview

In response to this:

/override ci/prow/e2e-openstack-ovn-techpreview

It is quite borked at the moment, and for sure it is not failing for this AWS specific field. Also the overall CAPI Openstack jobs is passing happily e2e-openstack-capi-techpreview. Overriding..

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[damdo]

/tide refresh

[damdo]

/retest-required

[damdo]

/retest

[damdo]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a17bce7 and 2 for PR HEAD 6808502 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a17bce7 and 2 for PR HEAD 6808502 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a17bce7 and 2 for PR HEAD 6808502 in total

[damdo]

/override ci/prow/e2e-openstack-ovn-techpreview

It is quite borked at the moment, and for sure it is not failing for this AWS specific field. Also the overall CAPI Openstack jobs is passing happily e2e-openstack-capi-techpreview. Overriding..

[openshift-ci]

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-openstack-ovn-techpreview

In response to this:

/override ci/prow/e2e-openstack-ovn-techpreview

It is quite borked at the moment, and for sure it is not failing for this AWS specific field. Also the overall CAPI Openstack jobs is passing happily e2e-openstack-capi-techpreview. Overriding..

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@chrischdi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	6808502	link	unknown	/test unit
ci/prow/e2e-azure-ovn-techpreview-upgrade	6808502	link	unknown	/test e2e-azure-ovn-techpreview-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.