Skip to content

Conversation

@pierreprinetti
Copy link
Member

Prior to this change, the feature-flag disabled all updates. With this
change, the feature-flag only disables master updates, as originally
intended.

Prior to this change, the feature-flag disabled all updates. With this
change, the feature-flag only disables master updates, as originally
intended.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2019
@openshift-ci-robot
Copy link

@pierreprinetti: This pull request references Bugzilla bug 1751471, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1751471: Apply update to workers selectively

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 5, 2019
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2019
@pierreprinetti
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 5, 2019
@openshift-ci-robot
Copy link

@pierreprinetti: This pull request references Bugzilla bug 1751471, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 5, 2019

WIP until I manage to deploy my local CAPO; the release image registry.svc.ci.openshift.org/origin/release:4.3 seems not to collaborate at the moment.

@pierreprinetti
Copy link
Member Author

I am currently unable to run OCP with a custom CAPO.

I am tentatively setting this PR as "ready for review" in case someone manages to test it successfully.

Otherwise, I will come back to it next week and test it properly myself.

@pierreprinetti pierreprinetti marked this pull request as ready for review December 10, 2019 08:15
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2019
@iamemilio iamemilio changed the title Bug 1751471: Apply update to workers selectively [WIP] Bug 1751471: Apply update to workers selectively Dec 10, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2019
@iamemilio
Copy link

The code looks good. Marking as WIP until we are able to test if this code provides the intended feature or not.

@pierreprinetti
Copy link
Member Author

Marking as WIP until we are able to test if this code provides the intended feature or not.

I believe this is also part of the LGTM process

@iamemilio
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamemilio, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [iamemilio,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamemilio
Copy link

/hold cancel

@iamemilio iamemilio changed the title [WIP] Bug 1751471: Apply update to workers selectively Bug 1751471: Apply update to workers selectively Jan 2, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit db51683 into openshift:master Jan 2, 2020
@openshift-ci-robot
Copy link

@pierreprinetti: All pull requests linked via external trackers have merged. Bugzilla bug 1751471 has been moved to the MODIFIED state.

In response to this:

Bug 1751471: Apply update to workers selectively

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the bug1751471 branch January 2, 2020 15:56
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Use 443 as the apiserver port until cluster-api allows us to set a
different port instead of hard-coding it:

kubernetes-sigs#64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants