-
Notifications
You must be signed in to change notification settings - Fork 33
Bug 1751471: Apply update to workers selectively #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1751471: Apply update to workers selectively #77
Conversation
Prior to this change, the feature-flag disabled all updates. With this change, the feature-flag only disables master updates, as originally intended.
|
@pierreprinetti: This pull request references Bugzilla bug 1751471, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@pierreprinetti: This pull request references Bugzilla bug 1751471, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
WIP until I manage to deploy my local CAPO; the release image |
|
I am currently unable to run OCP with a custom CAPO. I am tentatively setting this PR as "ready for review" in case someone manages to test it successfully. Otherwise, I will come back to it next week and test it properly myself. |
|
The code looks good. Marking as WIP until we are able to test if this code provides the intended feature or not. |
I believe this is also part of the LGTM process |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamemilio, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
@pierreprinetti: All pull requests linked via external trackers have merged. Bugzilla bug 1751471 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Use 443 as the apiserver port until cluster-api allows us to set a different port instead of hard-coding it: kubernetes-sigs#64
Prior to this change, the feature-flag disabled all updates. With this
change, the feature-flag only disables master updates, as originally
intended.