Bug 1746021: Abort Instance if no valid network

[pierreprinetti]

The Machine service, upon machine creation, looks in OpenStack for
networks and subnets matching the Machine Networks specificiation.

Before this change, if no matching network was found, the Instance spec
was sent to OpenStack with an empty Network segment.

With this change, the Machine service returns an error to the caller if
no matching networks are found in Openstack.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1746021

[openshift-ci-robot]

@pierreprinetti: This pull request references Bugzilla bug 1746021, which is invalid:

• expected the bug to target the "4.2.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1746021: Abort Instance if no valid network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierreprinetti]

/bugzilla refresh

[openshift-ci-robot]

@pierreprinetti: This pull request references Bugzilla bug 1746021, which is invalid:

• expected the bug to target the "4.2.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mandre]

The fix looks good me me. We should indeed stop sending requests that nova can't handle.

One question, though. Shouldn't this go in upstream k8s CAPO too?

[pierreprinetti]

Shouldn't this go in upstream k8s CAPO too?

To my (very limited) knowledge, there is no upstream Machine counterpart. But I might be wrong?

[pierreprinetti]

/bugzilla refresh

[openshift-ci-robot]

@pierreprinetti: This pull request references Bugzilla bug 1746021, which is invalid:

• expected the bug to target the "4.2.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierreprinetti]

/assign @Fedosin
...like the bot suggested :)

[pierreprinetti]

/bugzilla refresh

[openshift-ci-robot]

@pierreprinetti: This pull request references Bugzilla bug 1746021, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Fedosin]

/lgtm
/approve

We need to push it in upstream as well :) https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/pkg/cloud/services/compute/instance.go#L132

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Fedosin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierreprinetti]

We need to push it in upstream as well

Thanks for the link! I've been unsuccessfully looking for that

[openshift-ci-robot]

@pierreprinetti: All pull requests linked via external trackers have merged. Bugzilla bug 1746021 has been moved to the MODIFIED state.

In response to this:

Bug 1746021: Abort Instance if no valid network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.