Bug 1746015: Return error if instance deletion fails #60
Conversation
Now if CAPO cannot create an instance it ignores the error and continue operating as the deletion was successful. This patch returns the error if something wrong happens.
|
@Fedosin: This pull request references Bugzilla bug 1746015, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Fedosin: All pull requests linked via external trackers have merged. Bugzilla bug 1746015 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Update kubeadm's config to alpha3 * Update kubelet version to 1.12.1 We had 1.9.4 in our templates. It's time to update the kubelet version. This will require users of minikube <30 to also add `--minikube kubernetes-version=v1.12.1` to their `clusterctl` command. * Recommend using v1.12.1 Deployments using v1.10.0 are broken unless `--feature-gates=CustomResourceSubresources=true` is passed to the cluster creation and `.spec.subresources.status` is added to the CRD definition. Rather than doing that and forcing the use of an older version of k8s, let's take this opportunity to update the minimum required version to the latest available.
* Update kubeadm's config to alpha3 * Update kubelet version to 1.12.1 We had 1.9.4 in our templates. It's time to update the kubelet version. This will require users of minikube <30 to also add `--minikube kubernetes-version=v1.12.1` to their `clusterctl` command. * Recommend using v1.12.1 Deployments using v1.10.0 are broken unless `--feature-gates=CustomResourceSubresources=true` is passed to the cluster creation and `.spec.subresources.status` is added to the CRD definition. Rather than doing that and forcing the use of an older version of k8s, let's take this opportunity to update the minimum required version to the latest available.
4 participants
Now if CAPO cannot create an instance it ignores the error and continue operating as the deletion was successful.
This patch returns the error if something wrong happens.