Bug 1745939: Return error if image creation fails #59
Conversation
Now if CAPO cannot create an image it ignores the error and continue operating as the creation was successful. This patch returns the error if something wrong happens.
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@Fedosin: This pull request references Bugzilla bug 1745939, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
approved
|
/retest The CI errors seem to be MOC connection issues. Looks like there was an outage. |
|
/hold The @Fedosin this sounds like something we want to do upstream too. Would you please create that PR as well? We can merge this beforehand, but there's nothing OpenShift-specific about this change. |
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tomassedovic hi! thank you for the review... |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@Fedosin: All pull requests linked via external trackers have merged. Bugzilla bug 1745939 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit removes the Name field from the provider config. Instead of accepting an arbitrary name, we should be using the one provided by the machine resource itself.
This commit removes the Name field from the provider config. Instead of accepting an arbitrary name, we should be using the one provided by the machine resource itself.
4 participants
Now if CAPO cannot create an image it ignores the error and continue operating as the creation was successful.
This patch returns the error if something wrong happens.