Add InternalDNS annotation #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
Fedosin
force-pushed
the
set_node_internal_dns
branch
2 times, most recently
from
ca10a9e to
65cef45
Compare
Fedosin
force-pushed
the
set_node_internal_dns
branch
from
65cef45 to
4d5dae2
Compare
|
/lgtm Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Member
|
👍 |
racheljpg
pushed a commit
to racheljpg/cluster-api-provider-openstack
that referenced
this pull request
Dec 20, 2023
* make script executable * remove duplicate newlines * explicitly indicate sed command * Fix output for sh buildins on Darwin
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
* make script executable * remove duplicate newlines * explicitly indicate sed command * Fix output for sh buildins on Darwin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.