OCPBUGS-65712: Fix instance deletion order

[mandre]

Delete the OpenStack instance before deleting its network ports. This prevents "Policy doesn't allow compute:detach primary port" errors that occur when attempting to delete a primary NIC while the instance still exists.

Deleting the instance automatically detaches all interfaces, so the explicit detach call is no longer needed.

[openshift-ci-robot]

@mandre: This pull request references Jira Issue OCPBUGS-65712, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-65712 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Delete the OpenStack instance before deleting its network ports. This prevents "Policy doesn't allow compute:detach primary port" errors that occur when attempting to delete a primary NIC while the instance still exists.

Deleting the instance automatically detaches all interfaces, so the explicit detach call is no longer needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stephenfin]

This is effectively the same thing we currently do in (the much changed) upstream.

/lgtm
/approve

[mandre]

/hold
Waiting for CI to succeed on kubernetes-sigs#2842.

[stephenfin]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephenfin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@mandre: Jira Issue OCPBUGS-65712: All pull requests linked via external trackers have merged:

• openshift/cluster-api-provider-openstack#383

Jira Issue OCPBUGS-65712 has been moved to the MODIFIED state.

In response to this:

Delete the OpenStack instance before deleting its network ports. This prevents "Policy doesn't allow compute:detach primary port" errors that occur when attempting to delete a primary NIC while the instance still exists.

Deleting the instance automatically detaches all interfaces, so the explicit detach call is no longer needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mandre]

/hold cancel