OCPBUGS-44455: Merge https://github.com/kubernetes-sigs/cluster-api-provider-openstack:release-0.10 into release-4.17 #343
Conversation
When a floating is created, we need to make sure that `OpenStackCluster.Spec.DisableExternalNetwork` is not set to `True`. Otherwise, we'll have a nil pointer error. * Add a check in `reconcileBastion` to check that external network is not disabled before creating the floating IP for the bastion. * Add a check in `reconcileControlPlaneEndpoint` and `reconcileAPIServerLoadBalancer` to check that external network is not disabled (alongside the DisableAPIServerFloatingIP check) before creating the floating IP for the API server endpoint. * Add a safeguard in `GetOrCreateFloatingIP` to return a proper error (instead of a nil pointer error) when `openStackCluster.Status.ExternalNetwork` is nil. * Add API CEL to check that when DisableExternalNetwork is set and true, the bastion (if defined) doesn't have a floating IP defined and also that disableAPIServerFloatingIP (when set) is not False. (cherry picked from commit 5429b4b)
…-0.10-fip [release-0.10] 🐛 Better checks before creating Floating IPs
If the bastion image is missing or ambiguous, we do not have a bastion. In that case, we must continue with the deletion or be permanently stuck. Signed-off-by: Lennart Jern <[email protected]>
…ot/cherry-pick-2289-to-release-0.10 [release-0.10] 🌱 Automate the release process
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @shiftstack-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/lgtm |
openshift-ci
bot
added
lgtm
…ion-deletion-release-0.10 🐛 Fix deletion of cluster when bastion image missing
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-release-4.17
branch
from
a8202ba to
4ef1ea9
Compare
|
/lgtm |
This makes it possible to set up a local devstack on libvirt. It is probably not useful for running the full e2e suite (unless you have a very beefy PC), but it is enough for development with Tilt. Signed-off-by: Lennart Jern <[email protected]>
This is an attempt to make it more stable. Signed-off-by: Lennart Jern <[email protected]> (cherry picked from commit 5a86c5a)
While we investigate the issues with flatcar images further [1]. [1] https://bugs.launchpad.net/nova/+bug/2091114 Signed-off-by: Stephen Finucane <[email protected]> (cherry picked from commit 0a28aae)
…ot/cherry-pick-2262-to-release-0.10 [release-0.10] 🌱 Add libvirt resource type for create_devstack.sh + Run devstack on ubuntu 24.04
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-release-4.17
branch
from
4ef1ea9 to
9dd79c9
Compare
Configuring the following in devstack: ``` ENABLE_SYSCTL_MEM_TUNING="True" ENABLE_SYSCTL_NET_TUNING="True" ENABLE_ZSWAP="True" ``` That tuning is what is done in the `devstack-platform-ubuntu-noble` job. Example: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d17/936669/2/check/devstack-platform-ubuntu-noble/d178dad/controller/logs/local_conf.txt
…ot/cherry-pick-2307-to-release-0.10 [release-0.10] 🐛 ci/devstack: host tuning
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-release-4.17
branch
from
9dd79c9 to
8af72be
Compare
…orts-tags-release-0.10 🐛 Ensure that existing ports also have correct tags and trunks
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-release-4.17
branch
from
9d520c4 to
17bca54
Compare
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
…ot/cherry-pick-2541-to-release-0.10 [release-0.10] 🐛 allow switching from filter.name to id of network and subnets in OSC spec
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-release-4.17
branch
from
17bca54 to
02682af
Compare
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
/retest |
|
It's currently failing to build because this commit uses the slices package which was removed downstream in fe2962b665bc74d64710257a288d76bcfd95ff92 for go 1.21 compatibility. It seems like the slices package in go 1.21 has the Equal and Sort functions so we should be able to resolve the build failure by re-adding the |
New commits were added that depend on slices functions available in go 1.21.
|
/lifecycle frozen |
|
@mandre: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/remove-lifecycle rotten |
openshift-ci
bot
removed
the
lifecycle/rotten
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/label backport-risk-assessed
openshift-ci
bot
added
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@shiftstack-merge-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 5593c5f
into
openshift:release-4.17
|
@shiftstack-merge-bot[bot]: Jira Issue OCPBUGS-44455: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-44455 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openstack-cluster-api-controllers |
|
Fix included in accepted release 4.17.0-0.nightly-2025-06-23-191650 |
11 participants
No description provided.