Skip to content

Conversation

@EmilienM
Copy link
Member

@EmilienM EmilienM commented Nov 12, 2024

What this PR does / why we need it:

Manual merge to handle a git conflict in go.mod.
This was because we fixed the CAPI/tests version before upstream did and that caused
a merge problem. We fix it here.

What I did:

git clone https://github.com/openshift/cluster-api-provider-openstack.git
git remote add openshift https://github.com/openshift/cluster-api-provider-openstack.git
git remote add kubernetes https://github.com/kubernetes-sigs/cluster-api-provider-openstack.git
git fetch kubernetes release-0.11
git checkout -b merge-main
git merge kubernetes/release-0.11 --no-commit
<resolve the conflict in go.mod>
go mod tidy && go mod vendor
git add go.mod go.sum
git rebase --continue
make merge-bot
git commit -a -m "CARRY: run `merge-bot`"

Commits from upstream:

  • rm caBundle
  • [manual-backport-0.11] Bump CAPI to v1.8.5
  • 🌱(deps): Bump sigs.k8s.io/cluster-api/test
  • 🌱(deps): Bump golang.org/x/text from 0.19.0 to 0.20.0
  • 🌱(deps): Bump sigs.k8s.io/controller-tools in /hack/tools
  • Update generated code
  • Update generated code
  • Update generated code
  • 🌱(deps): Bump sigs.k8s.io/kustomize/kustomize/v5 in /hack/tools
  • Update generated code
  • 🌱(deps): Bump golang.org/x/crypto from 0.28.0 to 0.29.0
  • Update generated code

reyvonger and others added 20 commits November 6, 2024 20:08
…ot/cherry-pick-2238-to-release-0.11

[release-0.11] 🐛 Drop caBundle from CRDs to support Kubernetes 1.31
🌱 [manual-backport-0.11] Bump CAPI to v1.8.5
Bumps the capi group with 1 update in the / directory: [sigs.k8s.io/cluster-api/test](https://github.com/kubernetes-sigs/cluster-api).


Updates `sigs.k8s.io/cluster-api/test` from 1.8.4 to 1.8.5
- [Release notes](https://github.com/kubernetes-sigs/cluster-api/releases)
- [Commits](kubernetes-sigs/cluster-api@v1.8.4...v1.8.5)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/cluster-api/test
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: capi
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.19.0 to 0.20.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.19.0...v0.20.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) from 0.16.4 to 0.16.5.
- [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/main/envtest-releases.yaml)
- [Commits](kubernetes-sigs/controller-tools@v0.16.4...v0.16.5)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-tools
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…ot/go_modules/release-0.11/golang.org/x/text-0.20.0

🌱(deps): Bump golang.org/x/text from 0.19.0 to 0.20.0
…ot/go_modules/release-0.11/capi-89dea2d6e0

🌱(deps): Bump sigs.k8s.io/cluster-api/test from 1.8.4 to 1.8.5 in the capi group across 1 directory
…ot/go_modules/hack/tools/release-0.11/sigs.k8s.io/controller-tools-0.16.5

🌱(deps): Bump sigs.k8s.io/controller-tools from 0.16.4 to 0.16.5 in /hack/tools
Bumps [sigs.k8s.io/kustomize/kustomize/v5](https://github.com/kubernetes-sigs/kustomize) from 5.2.1 to 5.5.0.
- [Release notes](https://github.com/kubernetes-sigs/kustomize/releases)
- [Commits](kubernetes-sigs/kustomize@kustomize/v5.2.1...kustomize/v5.5.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/kustomize/kustomize/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…ot/go_modules/hack/tools/release-0.11/sigs.k8s.io/kustomize/kustomize/v5-5.5.0

🌱(deps): Bump sigs.k8s.io/kustomize/kustomize/v5 from 5.2.1 to 5.5.0 in /hack/tools
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.28.0 to 0.29.0.
- [Commits](golang/crypto@v0.28.0...v0.29.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…ot/go_modules/release-0.11/golang.org/x/crypto-0.29.0

🌱(deps): Bump golang.org/x/crypto from 0.28.0 to 0.29.0
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 12, 2024
@openshift-ci-robot
Copy link

@EmilienM: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:

Manual merge to handle a git conflict in go.mod.
This was because we fixed the CAPI/tests version before upstream did and that caused
a merge problem. We fix it here.

  • rm caBundle
  • [manual-backport-0.11] Bump CAPI to v1.8.5
  • 🌱(deps): Bump sigs.k8s.io/cluster-api/test
  • 🌱(deps): Bump golang.org/x/text from 0.19.0 to 0.20.0
  • 🌱(deps): Bump sigs.k8s.io/controller-tools in /hack/tools
  • Update generated code
  • Update generated code
  • Update generated code
  • 🌱(deps): Bump sigs.k8s.io/kustomize/kustomize/v5 in /hack/tools
  • Update generated code
  • 🌱(deps): Bump golang.org/x/crypto from 0.28.0 to 0.29.0
  • Update generated code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM
Copy link
Member Author

/assign mandre

@EmilienM
Copy link
Member Author

/approve

@EmilienM
Copy link
Member Author

/hold for CI

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
@EmilienM
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024
We need this target so merge-bot target can run it.
@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2024

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 59101d2 into openshift:main Nov 13, 2024
7 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the merge-bot-4.11 branch November 13, 2024 06:59
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openstack-cluster-api-controllers
This PR has been included in build openstack-cluster-api-controllers-container-v4.19.0-202411130808.p0.g59101d2.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants