Skip to content

OCPBUGS-20761: deps: Upgrade golang.org/x/net to v0.17.0 #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

OCPBUGS-20761: deps: Upgrade golang.org/x/net to v0.17.0 #278

merged 1 commit into from
Nov 7, 2023

Conversation

@pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Oct 25, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 25, 2023

@pierreprinetti: This pull request references Jira Issue OCPBUGS-20761, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20780 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre
mandre reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though we're not using this branch directly in OCP, let's patch them.
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

@pierreprinetti: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-proxy 0a93a67 link false /test e2e-openstack-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre mandre added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eurijon
Copy link

eurijon commented Oct 25, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 25, 2023
@mandre
Copy link
Member

mandre commented Oct 26, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 26, 2023
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Oct 26, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 26, 2023

@pierreprinetti: This pull request references Jira Issue OCPBUGS-20761, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20780 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Nov 6, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2023

@pierreprinetti: This pull request references Jira Issue OCPBUGS-20761, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20780 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Nov 7, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2023

@pierreprinetti: This pull request references Jira Issue OCPBUGS-20761, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20780 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-20780 targets the "4.12.z" version, which is one of the valid target versions: 4.12.0, 4.12.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 4f21449 into openshift:release-4.11 Nov 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2023

@pierreprinetti: Jira Issue OCPBUGS-20761: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20761 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the net_4.11 branch November 7, 2023 10:53
@openshift-merge-robot
Copy link

openshift-merge-robot commented Nov 8, 2023

Fix included in accepted release 4.11.0-0.nightly-2023-11-07-194708

@openshift-bot
Copy link

openshift-bot commented Nov 21, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-openstack-machine-controllers-container-v4.11.0-202311211130.p0.g4f21449.assembly.stream for distgit ose-openstack-machine-controllers.
All builds following this will include this PR.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@pierreprinetti
Migrated kubeadm config to v1beta1 for kubeadm 1.14 (openshift#278)
94aae7e 
Kubeadm 1.14.0 does not support v1alpha3 for anything else than
migrating the config.

See: kubernetes/kubernetes#74025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

Assignees

@mandre mandre

@eurijon eurijon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pierreprinetti @openshift-ci-robot @eurijon @mandre @openshift-merge-robot @openshift-bot