Bug 1921656: Remove dependence on annotation to allow Server deletion #240
Conversation
If a failure happened while handling the Machine creation, the Machine can end up without an openstack-resourceId annotation. This makes the deletion of the Machine to fail as no Server ID was specified in the annotation. This commit fixes the issue by making the deletion rely on the Server ID retrieved prior to delete instead of using the annotation. Co-authored-by: Matthew Booth [email protected]
|
@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
MaysaMacedo
changed the title
openshift-ci
bot
added
bugzilla/severity-medium
|
@MaysaMacedo: This pull request references Bugzilla bug 1921656, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@MaysaMacedo: This pull request references Bugzilla bug 1921656, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@MaysaMacedo: This pull request references Bugzilla bug 1921656, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: eurijon. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-openstack |
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/label backport-risk-assessed
/retest
/hold for CI
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Testrun for e2e-openstack was a bloodbath. |
|
e2e-openstack-proxy succeeded and e2e-openstack seems to have failed for unrelated reasons. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
/retest |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@MaysaMacedo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@MaysaMacedo: All pull requests linked via external trackers have merged: Bugzilla bug 1921656 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Due to no external network given, a error will be reported but that's acceptable since we might not want to create router at all in some scenario.
6 participants
If a failure happened while handling the Machine creation,
the Machine can end up without an openstack-resourceId
annotation. This makes the deletion of the Machine to fail as
no Server ID was specified in the annotation. This commit fixes
the issue by making the deletion rely on the Server ID retrieved
prior to delete instead of using the annotation.
Co-authored-by: Matthew Booth [email protected]
Release note: