Bug 2097728: Don't fail on server delete returning HTTP 404 #238
Conversation
If a server create request to nova fails particularly early in the process, it might never actually result in a server resource being created. This means attempts to delete the server will result in a HTTP 404. This is fine. The server is already gone so there's no reason we can't simply ignore the error. Signed-off-by: Stephen Finucane <[email protected]>
openshift-ci
bot
added
bugzilla/severity-medium
|
@stephenfin: This pull request references Bugzilla bug 2097728, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@stephenfin: This pull request references Bugzilla bug 2097728, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: eurijon. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mdbooth
left a comment
mdbooth
left a comment
There was a problem hiding this comment.
I'd like to consider legacy CAPO 'frozen' at this point, especially as its test coverage isn't as good as we'd like. Consequently I don't think we should fix the same issue we can see here deleting ports until we see folks hitting it in practise.
This whole class of bug is already fixed in MAPO.
/lgtm
No need for this to be a warning as we've already determined it's okay to ignore. Signed-off-by: Stephen Finucane <[email protected]>
|
@stephenfin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/hold I wonder if it's really worth fixing. The bug seems not important enough to justify the trouble we'll have to go through to fix affected versions. If we want the fix in 4.10 (the version the bug was reported against, but it's likely present down to 4.6), we'd have to merge in master then backport to 4.11 before it can reach 4.10. We have no way of validating the fix in both master and 4.11 as CAPO is no longer used there. I'd be OK with closing the BZ with CURRENTVERSION. |
openshift-ci
bot
added
the
do-not-merge/hold
If we want this in, the process would be to close Bug 2097728 as CURRENTRELEASE, clone, target to 4.10 and merge this patch against |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
Okay, closed as |
|
@stephenfin: This pull request references Bugzilla bug 2097728. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit adds an extra key to allow for disabling the rendering steps for userData, which allows for scenarios where userData has been pre-rendered and it just needs to be passed down to the instance.
6 participants
What this PR does / why we need it:
If a server create request to nova fails particularly early in the process, it might never actually result in a server resource being created. This means attempts to delete the server will result in a HTTP 404. This is fine. The server is already gone so there's no reason we can't simply ignore the error.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):BZ 2097728
Special notes for your reviewer:
N/A
Release note: