Skip to content

[release-4.9] Bug 2064633: Ensure subnets belong to the queried network #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2022
Merged

[release-4.9] Bug 2064633: Ensure subnets belong to the queried network #222

merged 1 commit into from
Mar 24, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Mar 16, 2022

This is an automated cherry-pick of #219

/assign mandre

@mandre
Bug 2033862: Ensure subnets belong to the queried network
571ec4b 
There is a known issue with Cisco ACI [1] that causes the query to
return subnets that don't belong to the specified network. We can
workaround it and ensure the subnets really belong to the network.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=2027305
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2022
Merged
@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2022

@openshift-cherrypick-robot: Bugzilla bug 2050064 has been cloned as Bugzilla bug 2064633. Retitling PR to link against new bug.
/retitle [release-4.9] [release-4.10] Bug 2064633: Ensure subnets belong to the queried network

In response to this:

[release-4.9] [release-4.10] Bug 2050064: Ensure subnets belong to the queried network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] [release-4.10] Bug 2050064: Ensure subnets belong to the queried network [release-4.9] [release-4.10] Bug 2064633: Ensure subnets belong to the queried network Mar 16, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2064633, which is invalid:

  • expected dependent Bugzilla bug 2050064 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] [release-4.10] Bug 2064633: Ensure subnets belong to the queried network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre mandre changed the title [release-4.9] [release-4.10] Bug 2064633: Ensure subnets belong to the queried network [release-4.9] Bug 2064633: Ensure subnets belong to the queried network Mar 16, 2022
@mandre
Copy link
Member

mandre commented Mar 16, 2022

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2022

@mandre: This pull request references Bugzilla bug 2064633, which is invalid:

  • expected dependent Bugzilla bug 2050064 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Mar 21, 2022

/bugzilla refresh
/retest

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2022

@mandre: This pull request references Bugzilla bug 2064633, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2050064 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2050064 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: eurijon.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@mandre: This pull request references Bugzilla bug 2064633, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2050064 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2050064 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Mar 23, 2022

/test e2e-openstack-proxy

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-proxy 571ec4b link false /test e2e-openstack-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member

mandre commented Mar 23, 2022 •
edited
Loading

4.9 periodic proxy fails in a similar fashion to the e2e-openstack-proxy job. I believe it's safe to ignore the failure, and work on fixing the job.

edit: 4.9 proxy job failure tracked in https://bugzilla.redhat.com/show_bug.cgi?id=2064800

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 23, 2022
@dulek
Copy link

dulek commented Mar 23, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2022

@dulek: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre
mandre reviewed Mar 24, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2022
@mandre
Copy link
Member

mandre commented Mar 24, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
@openshift-bot
Copy link

openshift-bot commented Mar 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Mar 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@eurijon
Copy link

eurijon commented Mar 24, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit 32bf2f8 into openshift:release-4.9 Mar 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 24, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2064633 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2064633: Ensure subnets belong to the queried network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@luis5tb @pierreprinetti
Revert "Revert "Add kuryr support (openshift#61)"" (openshift#222)
8e40458 
This reverts commit 1ca3d81.

Problem was cluster-api-provider-openstack vendor was wrongly added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

@EmilienM EmilienM Awaiting requested review from EmilienM

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @mandre @dulek @openshift-bot @eurijon @openshift-merge-robot