Update and clean machine api dependencies #206
Conversation
kwoodson
requested review from
iamemilio
and removed request for
EmilienM and
pierreprinetti
|
@elmiko: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Thanks, looks good! We can merge this as soon as the tests pass. |
|
/cc @mandre |
|
@kwoodson: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mandre It appears the e2e-openstack passed but the proxy one failed. From looking at the tests, I don't think this is related. /test e2e-openstack-proxy |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Ah, interesting, I had the exact same change locally while I was looking a moving CAPO API to openshift/api. Thanks @kwoodson 👍 |
This patch adds deleting the kubeconfig file step in the Cluster Deletion section.
7 participants
What this PR does / why we need it:
The machine libraries from machine-api-operator have been moved to openshift/api. This PR removes the circular dependency that existed on the machine-api-operator which also brought in AWS and Azure. These are removed with this work.
Which issue(s) this PR fixes
Special notes for your reviewer:
There are zero code updates. This is a library update and a dependency clean up. This simplifies the dependencies, removes circular dependencies, removes AWS/Azure dependencies, and moves the libraries to their correct openshift/api location.
Release note: