Skip to content

Conversation

@elmiko
Copy link

@elmiko elmiko commented Feb 12, 2021

No description provided.

@openshift-ci-robot
Copy link

@elmiko: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

revendor from mao at commit 9643c3accfda8f6b63a3c722146a44c7291fc465 of release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fedosin after the PR has been reviewed.
You can assign the PR to them by writing /assign @fedosin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elmiko
Copy link
Author

elmiko commented Feb 12, 2021

grabbed the wrong commit, closing and opening a new pr

@elmiko elmiko closed this Feb 12, 2021
@elmiko elmiko deleted the mao-update-9643c3accfda8f6b63a3c722146a44c7291fc465 branch February 12, 2021 19:44
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Some startup scripts do not require the endpoint to be available
(because they've got other means of bootstrapping for example) and
calling it right now would fail unconditionally.

Instead, this introduces a `GetMasterEndpoint` function that can be
called from the template via `"{{ call .GetMasterEndpoint }}` to query
the endpoint. Scripts that don't need it will not call this function.

Closes openshift#163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants