[cleanup] use gophercloud/utils to list available AZs #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have updated vendoring for gophercloud/utils, we can use the latest utils to list available AZs and stop maintaining our own function. Signed-off-by: Emilien Macchi <[email protected]>
pierreprinetti
approved these changes
Dec 21, 2020
Member
pierreprinetti
left a comment
pierreprinetti
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold - can wait for 4.8
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
openshift-ci-robot
removed
the
do-not-merge/hold
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
* Re-apply of new yq usage Just re-applied the usage of yq from openshift#135, because they were overridden by openshift#141. * Fixed var names CLOUD to OS_CLOUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have updated vendoring for gophercloud/utils, we can use the
latest utils to list available AZs and stop maintaining our own
function.