owners: Add mdbooth #136
owners: Add mdbooth #136
Conversation
Add a new team member
|
/cc @mdbooth |
|
@pierreprinetti: GitHub didn't allow me to request PR reviews from the following users: mdbooth. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
* Add a common ActuatorParams type This struct is passed to every Actuator and holds instance of objects that will be used throught the actuator lifecycle. Kubeclient, scheme, the manager client, etc. * Allow for the actuator to gather its configs from a secret. The config parsing logic is as follows: - Check if the machine has `CloudsSecret` set. If yes, get the secret, load the cloud from it using the value of `CloudName` (default is "openstack"), and use the credentials of this cloud. - If `CloudSecret` is not set, check for `clouds.yaml` files in the container and proceed using the standard flow. Some things to note: - As of now, if the `OS_CLOUD` env variable is set, and there's a `clouds.yaml` file in the container with a cloud corresponding to `OS_CLOUD`, it'll overwrite the one loaded from the secret. - The current implementation requires setting `CloudsSecret` on every machine definition. Future patches PRs will allow for setting `CloudsSecret` in the cluster spec too.
6 participants
Add a new team member