Skip to content

Bug 1855666: Update klog #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2020
Merged

Bug 1855666: Update klog #123

merged 1 commit into from
Sep 25, 2020

Conversation

@pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Sep 21, 2020 •
edited
Loading

  • Bump klog to v2.3.0

Kept gopkg.in/yaml to v2 to stay consistent with Kubernetes; v2 would be imported anyway as an indirect dependency.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 21, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 21, 2020

@pierreprinetti: This pull request references Bugzilla bug 1855666, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1855666: Update dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 21, 2020

@pierreprinetti: This pull request references Bugzilla bug 1855666, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1855666: Update dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 21, 2020

@pierreprinetti: This pull request references Bugzilla bug 1855666, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1855666: Update dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Sep 21, 2020

/cc Fedosin

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Sep 21, 2020

/retest

2 similar comments
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Sep 21, 2020

/retest

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Sep 22, 2020

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 22, 2020

@pierreprinetti: This pull request references Bugzilla bug 1855666, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1855666: Update dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Sep 22, 2020

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2020

@pierreprinetti: This pull request references Bugzilla bug 1855666, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1855666: Update dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Sep 23, 2020

/retest

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2020
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Sep 24, 2020

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2020

@pierreprinetti: This pull request references Bugzilla bug 1855666, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1855666: Update dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti changed the title Bug 1855666: Update dependencies Bug 1855666: Update klog Sep 24, 2020
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Sep 24, 2020

/retest

@mandre
Copy link
Member

mandre commented Sep 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@mandre
Copy link
Member

mandre commented Sep 25, 2020

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020
@openshift-merge-robot openshift-merge-robot merged commit c4127e1 into openshift:master Sep 25, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2020

@pierreprinetti: All pull requests linked via external trackers have merged:

Bugzilla bug 1855666 has been moved to the MODIFIED state.

In response to this:

Bug 1855666: Update klog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the bump branch September 25, 2020 08:15
@pierreprinetti pierreprinetti mentioned this pull request Sep 29, 2020
Merged
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@scruplelesswizard @pierreprinetti
Update examples to use 1.12.3 (openshift#123)
b1f0ce9 
Mitigation of CVE-2018-1002105
See kubernetes/kubernetes#71411 for more details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamemilio iamemilio Awaiting requested review from iamemilio

@mandre mandre Awaiting requested review from mandre

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierreprinetti @openshift-ci-robot @mandre @openshift-merge-robot