BUG 1858400: [Performance] Lease refresh period for machine-api-controllers is too high, causes heavy writes to etcd at idle #109
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@Danil-Grigorev: This pull request references Bugzilla bug 1858400, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@Danil-Grigorev: This pull request references Bugzilla bug 1858400, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@enxebre: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The machine-api-controller components are refreshing their lease more than all other components combined. Bringing this to 90s each, will decrease etcd writes at idle.
Danil-Grigorev
force-pushed
the
leader-elect-lease
branch
from
4c36fec to
288d15d
Compare
|
Fixed small typo in commit message. May I get LGTM @pierreprinetti @mandre? Thanks. |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Danil-Grigorev, enxebre, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@Danil-Grigorev: Some pull requests linked via external trackers have merged: openshift/machine-api-operator#649, openshift/cluster-api-provider-ovirt#56, openshift/cluster-api-provider-openstack#109, openshift/cluster-api-provider-gcp#104, openshift/cluster-api-provider-baremetal#88. The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Updated cluster-api for renaming ProviderConfig ... to ProviderSpec openshift#109 * Changed providerConfig to providerSpec also added two little railguards in the actuator, to not panic if there is no `providerSpec.Value`. In theory with this, it is possible to update the controller and edit existing manifests from `providerConfig` to `providerSpec`. * Fixed Gopkg.lock This resulted in removing a couple of corba license files
6 participants
What this PR does / why we need it:
The machine-api-controller components are refreshing their lease more
than all other components combined. Bringing this to 90s each, will
decrease etcd writes at idle.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes BUG 1858400
Special notes for your reviewer:
Relevant MAO PR - openshift/machine-api-operator#649
Release note: