forked from kubernetes-sigs/cluster-api-provider-openstack
-
Notifications
You must be signed in to change notification settings - Fork 33
Closed
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Description
/kind feature
Describe the solution you'd like
Currently, GetOrCreatePort only accepts very minimal security group definition1 (OpenStack UUID only), while the securityGroup definition under the instance spec allows for a richer name-based lookup of the security group.
Depending on the UUID requires that we must use an openstack client to lookup the SG UUID and cannot use the already-known name.
I would like GetOrCreatePort to either:
- find the security group based on the cluster name, that is: the same way it is defined under the machine's security group2, and/or
- default to the machine's securityGroup(s) (i.e. SecurityGroupParams), especially if it is undefined. (Currently, if port is defined without a securityGroup, it defaults to the openstack project's
defaultsecurity group, which is not the cluster'sworkersecurity group).
Anything else you would like to add:
ABHINAV-SUREKA
Metadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.