bugfix: avoided running init_by_lua* when test Nginx configuration wh… #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich contains lua_shared_dict directive. In commit 7c2b58e, we avoided running init_by_lua* in signaller processes and when testing the Nginx configuration. However, when the Nginx configuration contains lua_shared_dict directive, the execution of init_by_lua* will be postponded when testing the configuration. This case was not handled and led to the segmentation fault reported in GitHub issue openresty#1462.
|
@fancy-rabbit @thibaultcha @tokers |
thibaultcha
approved these changes
Jan 31, 2019
|
@spacewander Will you also port this change to the meta-lua module? |
|
Ported the fix to openresty/meta-lua-nginx-module#67 myself in which I made you a co-author, ofc :) |
|
@spacewander tested and worked like a charm. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ich contains lua_shared_dict directive.
In commit 7c2b58e, we avoided running init_by_lua* in signaller processes
and when testing the Nginx configuration. However, when the Nginx
configuration contains lua_shared_dict directive, the execution of
init_by_lua* will be postponded when testing the configuration.
This case was not handled and led to the segmentation fault reported in
GitHub issue #1462.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.