Skip to content

Fix Keepalive CLI option #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2022
Merged

Fix Keepalive CLI option #1443

merged 1 commit into from
Aug 18, 2022

Conversation

jjhursey
Copy link
Member

  • --keepalive takes a single parameter (pipe file descriptor)

@jjhursey
Fix Keepalive CLI option
d81f02c 
 * `--keepalive` takes a single parameter (pipe file descriptor)

Signed-off-by: Joshua Hursey <[email protected]>
@jjhursey jjhursey requested a review from rhc54 August 18, 2022 20:05
@jjhursey
Copy link
Member Author

Open MPI passed the pipe fd to this option here. Without this change the prte launched will segv when trying to access the opt->value[0] in prte.c

rhc54
rhc54 approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! Thanks for catching it!

@jjhursey jjhursey mentioned this pull request Aug 18, 2022
Closed
@rhc54 rhc54 merged commit 0937e7c into openpmix:master Aug 18, 2022
@jjhursey jjhursey deleted the fix-keepalive-cli branch August 18, 2022 20:44
@jjhursey jjhursey mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhc54 rhc54 rhc54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjhursey @rhc54