Use site's Next.js version #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: feature
Closed
lindsaylevine
added a commit
that referenced
this pull request
Dec 21, 2020
serhalp
pushed a commit
that referenced
this pull request
Apr 5, 2024
…le to avoid infinite loop (#73)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #25.
Instead of always using Next.js
9.5.3to requirenext/constantsandnext/dist/next-server/server/config, this PR re-uses the version of Next.js used in the site.It the site does not have Next.js installed, or if its version is
<9.5.3, the build will fail with an error message.This was previously reverted by #45. However, thanks to the new plugins installation flow, plugins can now require site's Node.js dependencies, which makes this PR work.