Some os-path touches #107
Merged
Some os-path touches #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the use of "path" arguments more consistent
This didn't cause any errors so far, but normalize-location didn't actually normalize the location (and if I'm not mistaken a location can well have . or .. elements.
While it isn't a type predicate it still returns #t or #f.
this-file-compiled? is already a copy of test-location? built into the os-path module. So this commit is removing redundancy.
|
OK, thank you for this change. Duplicate code can lead to really subtle bugs :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some touches to
os-pathrelated stuff, done while writing the documentation for that module:https://github.com/openlilylib/openlilylib/wiki/Path-Handling
@Cecca I only assigned this to you so you can see the last commit. This was what I mentioned recently.