Skip to content

Fix typedef regex to allow typedefs without contraints #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix typedef regex to allow typedefs without contraints #61

merged 1 commit into from
Sep 13, 2024

Conversation

Daniel-Knights
Copy link
Contributor

typedef tags are valid without a type constraint, but typedefRegEx requires one. This PR updates the regex to allow optional constraints, as well as any length whitespace.

ahocevar
ahocevar requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash these commits into one, to avoid the back and forth on trailing commas.

ahocevar
ahocevar approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Daniel-Knights

@ahocevar ahocevar merged commit 369ae45 into openlayers:main Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahocevar ahocevar ahocevar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daniel-Knights @ahocevar